Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1222833002: [turbofan] Cleanup Parameter creation in AstGraphBuilder. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup Parameter creation in AstGraphBuilder. R=bmeurer@chromium.org Committed: https://crrev.com/422e0c4a919d893512562b226ff70bdd00a39c12 Cr-Commit-Position: refs/heads/master@{#29488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 8 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-06 11:26:32 UTC) #1
Benedikt Meurer
Nice! LGTM
5 years, 5 months ago (2015-07-06 11:27:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222833002/1
5 years, 5 months ago (2015-07-06 11:34:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 11:50:04 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 11:50:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/422e0c4a919d893512562b226ff70bdd00a39c12
Cr-Commit-Position: refs/heads/master@{#29488}

Powered by Google App Engine
This is Rietveld 408576698