Issue 1222793008: Revert of V8 Buildbot: Skip test262 on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222793008: Revert of V8 Buildbot: Skip test262 on windows (Closed)

Created:
5 years, 5 months ago by Michael Achenbach

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

Revert of V8 Buildbot: Skip test262 on windows (patchset #1 id:1 of https://codereview.chromium.org/1221333004/) Reason for revert: Fixed v8 upstream. Original issue's description: > V8 Buildbot: Skip test262 on windows > > BUG=v8:4254 > TBR=tandrii@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295922 TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4254 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295934

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -2 lines)			Patch
M	scripts/slave/recipe_modules/v8/builders.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___debug.json	View	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

Created Revert of V8 Buildbot: Skip test262 on windows

5 years, 5 months ago (2015-07-07 10:34:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222793008/1

5 years, 5 months ago (2015-07-07 10:34:23 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295934

5 years, 5 months ago (2015-07-07 10:34:37 UTC) #3

Michael Achenbach

5 years, 5 months ago (2015-07-07 13:04:33 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1230483002/ by machenbach@chromium.org.

The reason for reverting is: Still fails..

Expand Messages | Collapse Messages