Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1222713013: [es6] unship harmony_rest_parameters (Closed)

Created:
5 years, 5 months ago by caitp (gmail)
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] unship harmony_rest_parameters BUG=508074 LOG=N R=arv@chromium.org, rossberg@chromium.org Committed: https://crrev.com/4a4d83683dff9d2fc6bd17aa1f10d6104077467d Cr-Commit-Position: refs/heads/master@{#29540}

Patch Set 1 #

Patch Set 2 : don't unstage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/flag-definitions.h View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
caitp (gmail)
here it is :( I think it needs unstaging otherwise you could still see problems ...
5 years, 5 months ago (2015-07-08 15:52:04 UTC) #1
arv (Not doing code reviews)
On 2015/07/08 15:52:04, caitp wrote: > here it is :( I think it needs unstaging ...
5 years, 5 months ago (2015-07-08 16:00:44 UTC) #2
caitp (gmail)
On 2015/07/08 16:00:44, arv wrote: > On 2015/07/08 15:52:04, caitp wrote: > > here it ...
5 years, 5 months ago (2015-07-08 16:02:03 UTC) #3
rossberg
On 2015/07/08 15:52:04, caitp wrote: > here it is :( I think it needs unstaging ...
5 years, 5 months ago (2015-07-08 16:02:30 UTC) #4
caitp (gmail)
On 2015/07/08 16:02:30, rossberg wrote: > On 2015/07/08 15:52:04, caitp wrote: > > here it ...
5 years, 5 months ago (2015-07-08 16:21:02 UTC) #5
arv (Not doing code reviews)
LGTM Please update the CL title and description.
5 years, 5 months ago (2015-07-08 16:22:11 UTC) #7
caitp (gmail)
On 2015/07/08 16:22:11, arv wrote: > LGTM > > Please update the CL title and ...
5 years, 5 months ago (2015-07-08 16:27:37 UTC) #8
rossberg
LGTM, thanks!
5 years, 5 months ago (2015-07-08 16:36:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222713013/20001
5 years, 5 months ago (2015-07-08 16:38:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 17:02:40 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 17:02:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a4d83683dff9d2fc6bd17aa1f10d6104077467d
Cr-Commit-Position: refs/heads/master@{#29540}

Powered by Google App Engine
This is Rietveld 408576698