Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1222673004: GN: Explicitly list out public headers in the blink_headers source_set (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke, esprehn
CC:
esprehn, blink-reviews, brettw, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

GN: Explicitly list out public headers in the blink_headers source_set This enables "gn check" to enforce that source files that #include these headers also declare a dependency on them in GN. This also fixes "gn check" on Android from having errors like: ERROR at //components/autofill/content/renderer/autofill_agent.cc:45:11: Include not allowed. ^-------------------------------------------- It is not in any dependency of //components/autofill/content/renderer:renderer The include file is in the target(s): //third_party/WebKit/public:blink_headers_java_enums_srcjar__generate_enum which should somehow be reachable. BUG=367595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198439

Patch Set 1 #

Patch Set 2 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -0 lines) Patch
M public/BUILD.gn View 1 1 chunk +509 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
agrieve
5 years, 5 months ago (2015-07-04 02:21:46 UTC) #2
Dirk Pranke
lgtm. +esprehn, fyi (this is the change I was talking about). At some point we ...
5 years, 5 months ago (2015-07-06 23:01:43 UTC) #3
esprehn
lgtm
5 years, 5 months ago (2015-07-06 23:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222673004/20001
5 years, 5 months ago (2015-07-07 23:34:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198439
5 years, 5 months ago (2015-07-08 01:06:51 UTC) #8
pdr.
5 years, 5 months ago (2015-07-08 17:59:45 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1224843009/ by pdr@chromium.org.

The reason for reverting is: This patch is causing build failures:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....

Powered by Google App Engine
This is Rietveld 408576698