Issue 1222673003: Add skyx packages for all the Sky demos (except game)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222673003: Add skyx packages for all the Sky demos (except game) (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add skyx packages for all the Sky demos (except game) This CL factors the skyx build logic out of sky/apk/rules.gni so that we can build skyx bundles without building entire APKs. This change makes it possible to build skyx bundles for all the examples (except game). TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f544ad62d7d00b7dbf3ef43172d597f834193c58

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -172 lines)			Patch
M	sky/apk/rules.gni	View		3 chunks	+10 lines, -79 lines	0 comments	Download
A +	sky/build/skyx.gni	View		5 chunks	+29 lines, -67 lines	0 comments	Download
M	sky/sdk/example/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/sdk/example/mine_digger/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/sdk/example/mine_digger/sky.yaml	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/sdk/example/rendering/BUILD.gn	View		1 chunk	+8 lines, -5 lines	0 comments	Download
M	sky/sdk/example/stocks/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/sdk/example/widgets/BUILD.gn	View		1 chunk	+13 lines, -5 lines	0 comments	Download
M	sky/sdk/home.dart	View	1	7 chunks	+10 lines, -8 lines	0 comments	Download
M	sky/tools/skyx.py	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	sky/tools/skyx/bin/skyx.dart	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-03 00:07:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f544ad62d7d00b7dbf3ef43172d597f834193c58 (presubmit successful).