Issue 1222663003: Rename ViewportObserver to SkyEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222663003: Rename ViewportObserver to SkyEngine (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rename ViewportObserver to SkyEngine The term ViewportObserver doesn't mean anything. This interface has evolved to control the engine. This new name reflects that. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1ff93e99814e05662cd4c625cd843138bb7d739b

Patch Set 1 #

Patch Set 2 : now with moar files #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -157 lines)			Patch
M	sky/sdk/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/services/engine/BUILD.gn	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	sky/services/engine/input_event.mojom	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/services/engine/sky_engine.mojom	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
D	sky/services/viewport/BUILD.gn	View		1 chunk	+0 lines, -12 lines	0 comments	Download
D	sky/services/viewport/input_event.mojom	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	sky/services/viewport/viewport_observer.mojom	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	sky/shell/BUILD.gn	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View		5 chunks	+12 lines, -12 lines	0 comments	Download
M	sky/shell/android/platform_view_android.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sky/shell/ios/sky_surface.mm	View		10 chunks	+17 lines, -18 lines	0 comments	Download
M	sky/shell/platform_view.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/shell/platform_view.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/shell/testing/test_runner.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/shell/testing/test_runner.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/shell/ui/engine.h	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	sky/shell/ui/engine.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	sky/shell/ui/input_event_converter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/ui_delegate.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-02 16:56:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:2) manually as
1ff93e99814e05662cd4c625cd843138bb7d739b (presubmit successful).

Expand Messages | Collapse Messages