Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1222663002: Make CompositeDataConsumerHandle non-copyable to pass compilation (Closed)

Created:
5 years, 5 months ago by hiroshige
Modified:
5 years, 5 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make CompositeDataConsumerHandle non-copyable to pass compilation Without WTF_MAKE_NONCOPYABLE(CompositeDataConsumerHandle), - Copy constructor is generated, and thus - RefPtr<Context>'s copy constructor is required, and thus - The definition of Context is required, but Context is forward declared. This results in compilation error if we include CompositeDataConsumerHandle.h from modules/ (except for CompositeDataConsumerHandle.cpp and tests) on win_blink_dbg bots. BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/modules/fetch/CompositeDataConsumerHandle.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222663002/1
5 years, 5 months ago (2015-07-02 13:03:21 UTC) #2
hiroshige
PTAL.
5 years, 5 months ago (2015-07-02 13:09:44 UTC) #4
yhirano
lgtm
5 years, 5 months ago (2015-07-02 13:16:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222663002/1
5 years, 5 months ago (2015-07-02 13:17:53 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 14:16:31 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198214

Powered by Google App Engine
This is Rietveld 408576698