Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1222643002: Update uconv.patch to exactly match upstream SVN r37045. (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update uconv.patch to exactly match upstream SVN r37045. This patch was sent upstream and modified before landing there. This CL reverse-applies uconv.patch, updates uconv.patch with a copy of SVN r37045, and re-applies the new patch. Notable changes include: - Renaming UCONFIG_NO_NON_HTML5_CONVERSION to UCONFIG_ONLY_HTML_CONVERSION. - Removing a few UCONFIG_ONLY_HTML_CONVERSION guards. - Fixing some unused variable warnings. - Cleaning up some comments. BUG=506434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -426 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M README.chromium View 1 chunk +1 line, -2 lines 0 comments Download
M icu.gyp View 1 chunk +1 line, -1 line 0 comments Download
M patches/uconv.patch View 21 chunks +327 lines, -307 lines 0 comments Download
M source/common/ucnv2022.cpp View 35 chunks +23 lines, -48 lines 0 comments Download
M source/common/ucnv_bld.cpp View 8 chunks +24 lines, -17 lines 0 comments Download
M source/common/ucnv_cnv.h View 1 chunk +1 line, -5 lines 0 comments Download
M source/common/ucnv_ct.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnv_lmb.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnv_u32.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnv_u7.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnv_u8.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnvbocu.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnvhz.c View 3 chunks +3 lines, -3 lines 0 comments Download
M source/common/ucnvisci.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/ucnvscsu.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/common/unicode/uconfig.h View 3 chunks +13 lines, -6 lines 0 comments Download
M source/common/unicode/urename.h View 2 chunks +0 lines, -6 lines 0 comments Download
M source/i18n/csdetect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M source/i18n/csr2022.h View 2 chunks +2 lines, -2 lines 0 comments Download
M source/i18n/csr2022.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M source/i18n/csrsbcs.h View 3 chunks +3 lines, -3 lines 0 comments Download
M source/i18n/csrsbcs.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Matt Giuca
See description on bug. Not urgent (I will disable Clang warnings on this library in ...
5 years, 5 months ago (2015-07-02 03:32:06 UTC) #2
jungshik at Google
On 2015/07/02 03:32:06, Matt Giuca wrote: > See description on bug. > > Not urgent ...
5 years, 5 months ago (2015-07-08 00:15:34 UTC) #3
Matt Giuca
5 years, 5 months ago (2015-07-08 01:57:25 UTC) #4
Message was sent while issue was closed.
OK.

Powered by Google App Engine
This is Rietveld 408576698