Issue 12226131: Work around dart2js' broken implementation of runtimeType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226131: Work around dart2js' broken implementation of runtimeType. (Closed)

Created:
7 years, 10 months ago by gram

Modified:
7 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Work around dart2js' broken implementation of runtimeType. Committed: https://code.google.com/p/dart/source/detail?r=18411

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	pkg/unittest/lib/src/core_matchers.dart	View		2 chunks	+16 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/12226131/diff/1/pkg/unittest/lib/src/core_matchers.dart File pkg/unittest/lib/src/core_matchers.dart (right): https://codereview.chromium.org/12226131/diff/1/pkg/unittest/lib/src/core_matchers.dart#newcode204 pkg/unittest/lib/src/core_matchers.dart:204: // So we play safe here. please file ...

7 years, 10 months ago (2013-02-12 23:09:17 UTC) #2

dgrove

7 years, 10 months ago (2013-02-12 23:31:31 UTC) #3

Message was sent while issue was closed.

+1 for a bug for this.

On 2013/02/12 23:09:17, Siggi Cherem (dart-lang) wrote:
> lgtm
> 
>
https://codereview.chromium.org/12226131/diff/1/pkg/unittest/lib/src/core_mat...
> File pkg/unittest/lib/src/core_matchers.dart (right):
> 
>
https://codereview.chromium.org/12226131/diff/1/pkg/unittest/lib/src/core_mat...
> pkg/unittest/lib/src/core_matchers.dart:204: // So we play safe here.
> please file a bug and add a reference here, I'm pretty sure kasper and stephen
> would be interested in this issue.

Expand Messages | Collapse Messages