tools/dom/scripts/htmlrenamer.py - Issue 12226129: Updating Element.scrollIntoView to be platform independent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmlrenamer.py

Issue 12226129: Updating Element.scrollIntoView to be platform independent. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/html/element_test.dart ('k') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | tools/dom/templates/html/impl/impl_Element.darttemplate » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/htmlrenamer.py

diff --git a/tools/dom/scripts/htmlrenamer.py b/tools/dom/scripts/htmlrenamer.py

index 7db5ce53c710abb96c790bb7f2025088bc6abf35..84c16484dd73625a29cd20595802c92c295dfb87 100644

--- a/tools/dom/scripts/htmlrenamer.py

+++ b/tools/dom/scripts/htmlrenamer.py

@@ -134,6 +134,9 @@ _private_html_members = monitored.Set('htmlrenamer._private_html_members', [

'Element.querySelectorAll',

'Element.removeAttribute',

'Element.removeAttributeNS',

+ 'Element.scrollIntoView',

+ 'Element.scrollIntoViewIfNeeded',

+ 'Element.setAttributeNS',

'Element.setAttribute',

'Element.setAttributeNS',

'ElementTraversal.childElementCount',

@@ -197,7 +200,6 @@ renamed_html_members = monitored.Dict('htmlrenamer.renamed_html_members', {

'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',

'DOMWindow.webkitRequestFileSystem': 'requestFileSystem',

'DOMWindow.webkitResolveLocalFileSystemURL': 'resolveLocalFileSystemUrl',

- 'Element.scrollIntoViewIfNeeded': 'scrollIntoView',

'Element.webkitCreateShadowRoot': 'createShadowRoot',

'Element.webkitMatchesSelector' : 'matches',

'Navigator.webkitGetUserMedia': '_getUserMedia',

@@ -336,7 +338,6 @@ _removed_html_members = monitored.Set('htmlrenamer._removed_html_members', [

'Element.innerText',

'Element.outerText',

'Element.removeAttributeNode',

- 'Element.scrollIntoView',

'Element.set:outerHTML',

'Element.setAttributeNode',

'Element.setAttributeNodeNS',