Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 12226119: Factor out duplicated GioMemoryFileSnapshotCtor() + NaClAppLoadFile() calls (Closed)

Created:
7 years, 10 months ago by Mark Seaborn
Modified:
7 years, 10 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Factor out duplicated GioMemoryFileSnapshotCtor() + NaClAppLoadFile() calls Introduce NaClAppLoadFileFromFilename() as a helper function for loading a nexe. This removes the need for many of the mini-sel_ldr tests to know about the gio layer and Valgrind. BUG=none TEST=small_tests Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -84 lines) Patch
M src/shared/gio/gio.h View 1 chunk +1 line, -1 line 0 comments Download
M src/shared/gio/gio_mem_snapshot.c View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/service_runtime/load_file.h View 1 chunk +23 lines, -0 lines 0 comments Download
A src/trusted/service_runtime/load_file.c View 1 chunk +35 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/mmap_test.c View 3 chunks +3 lines, -9 lines 0 comments Download
M src/trusted/service_runtime/sel_main.c View 3 chunks +2 lines, -18 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/custom_desc/desc_test_host.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/faulted_thread_queue/faultqueue_test_host.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/minnacl/minimal_test_host.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/signal_handler_single_step/regs_step_test_host.c View 4 chunks +2 lines, -6 lines 0 comments Download
M tests/signal_handler_single_step/step_test_host.c View 4 chunks +2 lines, -6 lines 0 comments Download
M tests/thread_suspension/suspend_test_host.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/trusted_crash/crash_in_syscall/test_host.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/trusted_crash/osx_crash_filter/crash_filter_test.c View 3 chunks +2 lines, -6 lines 0 comments Download
M tests/trusted_crash/osx_crash_forwarding/mach_crash_forwarding_test.c View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
7 years, 10 months ago (2013-02-12 19:17:30 UTC) #1
bradn
7 years, 10 months ago (2013-02-12 19:35:18 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698