Issue 12226110: Fixed unexpected scroll when removing profiles in settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226110: Fixed unexpected scroll when removing profiles in settings. (Closed)

Created:
7 years, 10 months ago by mtomasz

Modified:
7 years, 10 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed unexpected scroll when removing profiles in settings. The problem was caused by auto focusing to the first focusable control when switching pages. To show an overlay, a owning page is shown, very often to the same current one, what is causing setting focus to the first focusable item, and scrolling to the top just before showing an overlay. This patch addresses this issue by not changing focus if the current focused control is on the active page/overlay. TEST=Follow the bug's repro steps. BUG=174608 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182133

Patch Set 1 #

Patch Set 2 : Simplified. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/options_page.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

7 years, 10 months ago (2013-02-13 02:12:03 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12226110/2001

Expand Messages | Collapse Messages