Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: pkg/scheduled_test/test/scheduled_test_test.dart

Issue 12226103: Revert "Add built-in timeouts to scheduled_test." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/test/scheduled_test_test.dart
diff --git a/pkg/scheduled_test/test/scheduled_test_test.dart b/pkg/scheduled_test/test/scheduled_test_test.dart
index bb1545bed7a7671b3237e8ec36bfd69b2ec39150..4c14badc6b1e52520fcc5d79c242d4252129f455 100644
--- a/pkg/scheduled_test/test/scheduled_test_test.dart
+++ b/pkg/scheduled_test/test/scheduled_test_test.dart
@@ -583,41 +583,12 @@ void main() {
});
});
- expectTestsPass('currentSchedule.currentQueue is tasks before the schedule '
- 'has started', () {
+ expectTestsPass('currentSchedule.currentQueue is null before the schedule has '
+ 'started', () {
test('test', () {
schedule(() => expect('foo', equals('foo')));
- expect(currentSchedule.currentQueue.name, equals('tasks'));
- });
- });
-
- expectTestsPass('currentSchedule.state starts out as SET_UP', () {
- test('test', () {
- expect(currentSchedule.state, equals(ScheduleState.SET_UP));
- });
- });
-
- expectTestsPass('currentSchedule.state is RUNNING in tasks', () {
- test('test', () {
- schedule(() {
- expect(currentSchedule.state, equals(ScheduleState.RUNNING));
- });
-
- currentSchedule.onComplete.schedule(() {
- expect(currentSchedule.state, equals(ScheduleState.RUNNING));
- });
- });
- });
-
- expectTestsPass('currentSchedule.state is DONE after the test', () {
- var oldSchedule;
- test('test 1', () {
- oldSchedule = currentSchedule;
- });
-
- test('test 2', () {
- expect(oldSchedule.state, equals(ScheduleState.DONE));
+ expect(currentSchedule.currentQueue, isNull);
});
});
@@ -748,157 +719,4 @@ void main() {
});
});
});
-
- expectTestsPass("a single task that takes too long will cause a timeout "
- "error", () {
- var errors;
- test('test 1', () {
- currentSchedule.timeoutMs = 50;
-
- currentSchedule.onException.schedule(() {
- errors = currentSchedule.errors;
- });
-
- schedule(() => sleep(60));
- });
-
- test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals(["The schedule timed out after "
- "50ms of inactivity."]));
- });
- }, passing: ['test 2']);
-
- expectTestsPass("an out-of-band callback that takes too long will cause a "
- "timeout error", () {
- var errors;
- test('test 1', () {
- currentSchedule.timeoutMs = 50;
-
- currentSchedule.onException.schedule(() {
- errors = currentSchedule.errors;
- });
-
- sleep(60).then(wrapAsync((_) => expect('foo', equals('foo'))));
- });
-
- test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals(["The schedule timed out after "
- "50ms of inactivity."]));
- });
- }, passing: ['test 2']);
-
- expectTestsPass("each task resets the timeout timer", () {
- test('test', () {
- currentSchedule.timeoutMs = 50;
-
- schedule(() => sleep(30));
- schedule(() => sleep(30));
- schedule(() => sleep(30));
- });
- });
-
- expectTestsPass("setting up the test doesn't trigger a timeout", () {
- test('test', () {
- currentSchedule.timeoutMs = 20;
-
- var end = new DateTime.now().add(new Duration(milliseconds: 50));
- while (new DateTime.now() < end) {}
- schedule(() => expect('foo', equals('foo')));
- });
- });
-
- expectTestsPass("an out-of-band error that's signaled after a timeout but "
- "before the test completes is registered", () {
- var errors;
- test('test 1', () {
- currentSchedule.timeoutMs = 50;
-
- currentSchedule.onException.schedule(() => sleep(30));
- currentSchedule.onException.schedule(() {
- errors = currentSchedule.errors;
- });
-
- sleep(60).then(wrapAsync((_) {
- throw 'out-of-band';
- }));
- });
-
- test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals([
- "The schedule timed out after 50ms of inactivity.",
- "out-of-band"
- ]));
- });
- }, passing: ['test 2']);
-
- expectTestsPass("an out-of-band error that's signaled after a timeout but "
- "before the test completes plays nicely with other out-of-band callbacks",
- () {
- var errors;
- var onExceptionCallbackRun = false;
- var onCompleteRunAfterOnExceptionCallback = false;
- test('test 1', () {
- currentSchedule.timeoutMs = 50;
-
- currentSchedule.onException.schedule(() {
- sleep(30).then(wrapAsync((_) {
- onExceptionCallbackRun = true;
- }));
- });
-
- currentSchedule.onComplete.schedule(() {
- onCompleteRunAfterOnExceptionCallback = onExceptionCallbackRun;
- });
-
- sleep(60).then(wrapAsync((_) {
- throw 'out-of-band';
- }));
- });
-
- test('test 2', () {
- expect(onCompleteRunAfterOnExceptionCallback, isTrue);
- });
- }, passing: ['test 2']);
-
- expectTestsPass("a task that times out while waiting to handle an "
- "out-of-band error records both", () {
- var errors;
- test('test 1', () {
- currentSchedule.timeoutMs = 50;
-
- currentSchedule.onException.schedule(() {
- errors = currentSchedule.errors;
- });
-
- schedule(() => sleep(60));
- sleep(10).then((_) => currentSchedule.signalError('out-of-band'));
- });
-
- test('test 2', () {
- expect(errors, everyElement(new isInstanceOf<ScheduleError>()));
- expect(errors.map((e) => e.error), equals([
- "out-of-band",
- "The schedule timed out after 50ms of inactivity."
- ]));
- });
- }, passing: ['test 2']);
-
- expectTestsPass("currentSchedule.heartbeat resets the timeout timer", () {
- test('test', () {
- currentSchedule.timeoutMs = 50;
-
- schedule(() {
- return sleep(30).then((_) {
- currentSchedule.heartbeat();
- return sleep(30);
- });
- });
- });
- });
-
- // TODO(nweiz): test out-of-band post-timeout errors that are detected after
- // the test finishes once we can detect top-level errors (issue 8417).
}
« no previous file with comments | « pkg/scheduled_test/lib/src/substitute_future.dart ('k') | pkg/scheduled_test/test/substitute_future_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698