Issue 12226102: Fix crash when closing a constrained window in win aura. The crash happens because the aura::Window…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12226102: Fix crash when closing a constrained window in win aura. The crash happens because the aura::Window… (Closed)

Created:
7 years, 10 months ago by jam

Modified:
7 years, 10 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix crash when closing a constrained window in win aura. The crash happens because the aura::Window for the constrained window is removing itself from its parent window, and its parent_ pointer is already NULL'd before the focus manager is retrieved which fails because aura::client::GetFocusClient can't get to a root window. See the bug for the callstack. BUG=174727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181947

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	ui/views/widget/native_widget_aura.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages