Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.cc

Issue 12226095: Make synchronous methods on disk_cache::SimpleEntryImpl() reentrant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: on top of trunk, ready to land Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_synchronous_entry.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_synchronous_entry.cc
diff --git a/net/disk_cache/simple/simple_synchronous_entry.cc b/net/disk_cache/simple/simple_synchronous_entry.cc
index 6a8b7f5f9b5bcedf6f0044c5c7c18ec361353459..d8e5148f98a2c7971d542a6fec6fde9e27fccc57 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.cc
+++ b/net/disk_cache/simple/simple_synchronous_entry.cc
@@ -20,7 +20,6 @@
#include "base/task_runner.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
-#include "net/disk_cache/simple/simple_disk_format.h"
using base::ClosePlatformFile;
using base::FilePath;
@@ -104,7 +103,7 @@ void SimpleSynchronousEntry::DoomEntry(
const std::string& key,
scoped_refptr<TaskRunner> callback_runner,
const net::CompletionCallback& callback) {
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
FilePath to_delete = path.AppendASCII(GetFilenameForKeyAndIndex(key, i));
bool ALLOW_UNUSED result = file_util::Delete(to_delete, false);
DLOG_IF(ERROR, !result) << "Could not delete " << to_delete.MaybeAsASCII();
@@ -125,7 +124,7 @@ void SimpleSynchronousEntry::DoomAndClose() {
}
void SimpleSynchronousEntry::Close() {
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
bool ALLOW_UNUSED result = ClosePlatformFile(files_[i]);
DLOG_IF(INFO, !result) << "Could not Close() file.";
}
@@ -194,7 +193,7 @@ SimpleSynchronousEntry::~SimpleSynchronousEntry() {
}
bool SimpleSynchronousEntry::OpenOrCreateFiles(bool create) {
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
FilePath filename = path_.AppendASCII(GetFilenameForKeyAndIndex(key_, i));
int flags = PLATFORM_FILE_READ | PLATFORM_FILE_WRITE;
if (create)
@@ -216,7 +215,7 @@ bool SimpleSynchronousEntry::OpenOrCreateFiles(bool create) {
}
}
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
PlatformFileInfo file_info;
bool success = GetPlatformFileInfo(files_[i], &file_info);
if (!success) {
@@ -236,7 +235,7 @@ bool SimpleSynchronousEntry::InitializeForOpen() {
if (!OpenOrCreateFiles(false))
return false;
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
SimpleFileHeader header;
int header_read_result =
ReadPlatformFile(files_[i], 0, reinterpret_cast<char*>(&header),
@@ -292,7 +291,7 @@ bool SimpleSynchronousEntry::InitializeForCreate() {
return false;
}
- for (int i = 0; i < kIndexCount; ++i) {
+ for (int i = 0; i < kSimpleEntryFileCount; ++i) {
SimpleFileHeader header;
header.initial_magic_number = kSimpleInitialMagicNumber;
header.version = kSimpleVersion;
« no previous file with comments | « net/disk_cache/simple/simple_synchronous_entry.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698