Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: utils/tests/pub/pub_lish_test.dart

Issue 12226077: add --preview flag to publish command (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/command_lish.dart ('k') | utils/tests/pub/pub_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/pub_lish_test.dart
===================================================================
--- utils/tests/pub/pub_lish_test.dart (revision 18383)
+++ utils/tests/pub/pub_lish_test.dart (working copy)
@@ -81,36 +81,65 @@
// test that "pub lish" chooses the correct files to publish.
integration('package validation has an error', () {
- var package = package("test_pkg", "1.0.0");
- package.remove("homepage");
- dir(appPath, [pubspec(package)]).scheduleCreate();
+ var pkg = package("test_pkg", "1.0.0");
+ pkg.remove("homepage");
+ dir(appPath, [pubspec(pkg)]).scheduleCreate();
var server = new ScheduledServer();
var pub = startPubLish(server);
- pub.shouldExit(1);
+ pub.shouldExit(0);
expectLater(pub.remainingStderr(),
contains("Sorry, your package is missing a requirement and can't be "
"published yet."));
});
+ integration('preview package validation has a warning', () {
+ var pkg = package("test_pkg", "1.0.0");
+ pkg["author"] = "Nathan Weizenbaum";
+ dir(appPath, [pubspec(pkg)]).scheduleCreate();
+
+ var server = new ScheduledServer();
+ var pub = startPubLish(server, args: ['--dry-run']);
+
+ pub.shouldExit(0);
+ expectLater(pub.remainingStderr(),
+ contains('Suggestions:\n* Author "Nathan Weizenbaum" in pubspec.yaml'
+ ' should have an email address\n'
+ ' (e.g. "name <email>").\n\n'
+ 'Package has 1 warning.'));
+ });
+
+ integration('preview package validation has no warnings', () {
+ var pkg = package("test_pkg", "1.0.0");
+ pkg["author"] = "Nathan Weizenbaum <nweiz@google.com>";
+ dir(appPath, [pubspec(pkg)]).scheduleCreate();
+
+ var server = new ScheduledServer();
+ var pub = startPubLish(server, args: ['--dry-run']);
+
+ pub.shouldExit(0);
+ expectLater(pub.remainingStderr(),
+ contains('Package has 0 warnings.'));
+ });
+
integration('package validation has a warning and is canceled', () {
- var package = package("test_pkg", "1.0.0");
- package["author"] = "Nathan Weizenbaum";
- dir(appPath, [pubspec(package)]).scheduleCreate();
+ var pkg = package("test_pkg", "1.0.0");
+ pkg["author"] = "Nathan Weizenbaum";
+ dir(appPath, [pubspec(pkg)]).scheduleCreate();
var server = new ScheduledServer();
var pub = startPubLish(server);
pub.writeLine("n");
- pub.shouldExit(1);
+ pub.shouldExit(0);
expectLater(pub.remainingStderr(), contains("Package upload canceled."));
});
integration('package validation has a warning and continues', () {
- var package = package("test_pkg", "1.0.0");
- package["author"] = "Nathan Weizenbaum";
- dir(appPath, [pubspec(package)]).scheduleCreate();
+ var pkg = package("test_pkg", "1.0.0");
+ pkg["author"] = "Nathan Weizenbaum";
+ dir(appPath, [pubspec(pkg)]).scheduleCreate();
var server = new ScheduledServer();
credentialsFile(server, 'access token').scheduleCreate();
« no previous file with comments | « utils/pub/command_lish.dart ('k') | utils/tests/pub/pub_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698