add --preview flag to publish command

utils/tests/pub/pub_lish_test.dart

Index: utils/tests/pub/pub_lish_test.dart
===================================================================
--- utils/tests/pub/pub_lish_test.dart	(revision 18294)
+++ utils/tests/pub/pub_lish_test.dart	(working copy)
@@ -81,9 +81,9 @@
   // test that "pub lish" chooses the correct files to publish.
 
   integration('package validation has an error', () {
-    var package = package("test_pkg", "1.0.0");
-    package.remove("homepage");
-    dir(appPath, [pubspec(package)]).scheduleCreate();
+    var pkg = package("test_pkg", "1.0.0");
+    pkg.remove("homepage");
+    dir(appPath, [pubspec(pkg)]).scheduleCreate();
 
     var server = new ScheduledServer();
     var pub = startPubLish(server);
@@ -94,10 +94,42 @@
             "published yet."));
   });
 
+  integration('preview package validation has a warning', () {
+    var pkg = package("test_pkg", "1.0.0");
+    pkg["author"] = "Nathan Weizenbaum";
+    dir(appPath, [pubspec(pkg)]).scheduleCreate();
+
+    var server = new ScheduledServer();
+    var lishArgs = new List();
+    lishArgs.add("--dry-run");

[Bob Nystrom, 2013/02/11 18:44:37]

Eek, Java! :)

Just do:

startPubLish(server, args: ['--dry-run']);

[keertip, 2013/02/11 23:57:31]

Done.

+    var pub = startPubLish(server,args: lishArgs);

[Bob Nystrom, 2013/02/11 18:44:37]

Space after ",".

[keertip, 2013/02/11 23:57:31]

Done.

+
+    pub.shouldExit(0);

[Bob Nystrom, 2013/02/11 18:44:37]

Do we want a zero exit code for this? It might be helpful if it returned
non-zero on validation failure.

+    expectLater(pub.remainingStderr(),
+        contains('Suggestions:\n* Author "Nathan Weizenbaum" in pubspec.yaml '
+                  'should have an email address\n  (e.g. "name <email>").\n\n'

[Bob Nystrom, 2013/02/11 18:44:37]

Extra leading space here. Also, I'd split it at the "\n" just so that the code
matches the output a bit more:

'should have an email address\n'
'  (e.g. "name <email>").\n\n'

+                 'Package has 1 warning.'));
+  });
+  
+  integration('preview package validation has no warnings', () {
+    var pkg = package("test_pkg", "1.0.0");
+    pkg["author"] = "Nathan Weizenbaum <nweiz@google.com>";
+    dir(appPath, [pubspec(pkg)]).scheduleCreate();
+
+    var server = new ScheduledServer();
+    var lishArgs = new List();
+    lishArgs.add("--dry-run");
+    var pub = startPubLish(server,args: lishArgs);

[Bob Nystrom, 2013/02/11 18:44:37]

lishArgs -> ['--dry-run']

[keertip, 2013/02/11 23:57:31]

Done.

+
+    pub.shouldExit(0);
+    expectLater(pub.remainingStderr(),
+        contains('Package has 0 warnings.'));
+  });
+  
   integration('package validation has a warning and is canceled', () {
-    var package = package("test_pkg", "1.0.0");
-    package["author"] = "Nathan Weizenbaum";
-    dir(appPath, [pubspec(package)]).scheduleCreate();
+    var pkg = package("test_pkg", "1.0.0");
+    pkg["author"] = "Nathan Weizenbaum";
+    dir(appPath, [pubspec(pkg)]).scheduleCreate();
 
     var server = new ScheduledServer();
     var pub = startPubLish(server);
@@ -108,9 +140,9 @@
   });
 
   integration('package validation has a warning and continues', () {
-    var package = package("test_pkg", "1.0.0");
-    package["author"] = "Nathan Weizenbaum";
-    dir(appPath, [pubspec(package)]).scheduleCreate();
+    var pkg = package("test_pkg", "1.0.0");
+    pkg["author"] = "Nathan Weizenbaum";
+    dir(appPath, [pubspec(pkg)]).scheduleCreate();
 
     var server = new ScheduledServer();
     credentialsFile(server, 'access token').scheduleCreate();