Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12226061: Move renderer accessibility to subdir and add OWNERS (Closed)

Created:
7 years, 10 months ago by dmazzoni
Modified:
7 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Move renderer accessibility to subdir and add OWNERS Creates a subdirectory for accessibility in content/renderer and adds an OWNERS file that matches content/browser/accessibility. Adds per-file OWNERS for accessibility-only files in content/common. The exception is the IPC file, just to be safe - this still requires separate review when changed: content/common/accessibility_messages.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181447

Patch Set 1 #

Total comments: 2

Patch Set 2 : Create subdir in renderer #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1968 lines) Patch
M content/common/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + content/renderer/accessibility/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/renderer/accessibility/accessibility_node_serializer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/accessibility/accessibility_node_serializer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/accessibility/renderer_accessibility.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/accessibility/renderer_accessibility.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/accessibility/renderer_accessibility_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/accessibility/renderer_accessibility_complete.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/accessibility/renderer_accessibility_complete.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + content/renderer/accessibility/renderer_accessibility_focus_only.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/renderer/accessibility/renderer_accessibility_focus_only.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/accessibility_node_serializer.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
D content/renderer/accessibility_node_serializer.cc View 1 1 chunk +0 lines, -629 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
D content/renderer/renderer_accessibility.h View 1 1 chunk +0 lines, -83 lines 0 comments Download
D content/renderer/renderer_accessibility.cc View 1 1 chunk +0 lines, -99 lines 0 comments Download
D content/renderer/renderer_accessibility_browsertest.cc View 1 1 chunk +0 lines, -192 lines 0 comments Download
D content/renderer/renderer_accessibility_complete.h View 1 1 chunk +0 lines, -140 lines 0 comments Download
D content/renderer/renderer_accessibility_complete.cc View 1 2 1 chunk +0 lines, -546 lines 0 comments Download
D content/renderer/renderer_accessibility_focus_only.h View 1 1 chunk +0 lines, -75 lines 0 comments Download
D content/renderer/renderer_accessibility_focus_only.cc View 1 1 chunk +0 lines, -153 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
7 years, 10 months ago (2013-02-07 18:01:55 UTC) #1
jam
https://codereview.chromium.org/12226061/diff/1/content/renderer/OWNERS File content/renderer/OWNERS (right): https://codereview.chromium.org/12226061/diff/1/content/renderer/OWNERS#newcode5 content/renderer/OWNERS:5: per-file *accessibility*=dtseng@chromium.org i just noticed that there are 9 ...
7 years, 10 months ago (2013-02-07 18:06:05 UTC) #2
dmazzoni
https://codereview.chromium.org/12226061/diff/1/content/renderer/OWNERS File content/renderer/OWNERS (right): https://codereview.chromium.org/12226061/diff/1/content/renderer/OWNERS#newcode5 content/renderer/OWNERS:5: per-file *accessibility*=dtseng@chromium.org On 2013/02/07 18:06:05, jam wrote: > i ...
7 years, 10 months ago (2013-02-07 18:48:03 UTC) #3
jam
lgtm, thanks
7 years, 10 months ago (2013-02-07 19:14:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/12226061/5002
7 years, 10 months ago (2013-02-08 03:36:13 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-08 07:23:44 UTC) #6
Message was sent while issue was closed. 
Change committed as 181447

Powered by Google App Engine
This is Rietveld 408576698