Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 12226045: Linux/ChromeOS Chromium style checker cleanup, chrome/ edition part 1. (Closed)

Created:
7 years, 10 months ago by Ryan Sleevi
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, cbentzel+watch_chromium.org, David Black, melevin, jar (doing other things), gideonwald, apatrick_chromium, sreeram, dominich, Aaron Boodman, darin-cc_chromium.org, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Ilya Sherman, MAD, Jered
Visibility:
Public.

Description

Linux/ChromeOS Chromium style checker cleanup, chrome/ edition part 1. Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -127 lines) Patch
M chrome/common/extensions/unpacker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/json_schema_validator_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/metrics/entropy_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/metrics/metrics_log_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/multi_process_lock_linux.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/worker_thread_ticker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/nacl/nacl_listener.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/nacl/nacl_validation_query_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/app_window_custom_bindings.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/content_watcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/module_system_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/external_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_click_tracker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/service/service_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/module_system_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/ui_controls_aurax11.cc View 4 chunks +22 lines, -18 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/security_tests/sandbox_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/ipclist/ipcfuzz.cc View 4 chunks +35 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
sky: Please consider rubberstamping. This is an automated fixup that was generated by our Clang ...
7 years, 10 months ago (2013-02-06 22:03:35 UTC) #1
sky
LGTM
7 years, 10 months ago (2013-02-06 23:56:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12226045/1
7 years, 10 months ago (2013-02-07 00:03:01 UTC) #3
commit-bot: I haz the power
Presubmit check for 12226045-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-07 00:03:15 UTC) #4
Ryan Sleevi
NOTRY because of stupid wstring
7 years, 10 months ago (2013-02-07 01:18:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/12226045/1
7 years, 10 months ago (2013-02-07 01:30:59 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-07 01:31:22 UTC) #7
Presubmit check for 12226045-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    chrome/tools/ipclist/ipcfuzz.cc:186
    chrome/tools/ipclist/ipcfuzz.cc:237

Presubmit checks took 3.9s to calculate.

Powered by Google App Engine
This is Rietveld 408576698