Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chrome/test/chromedriver/run_py_tests.py

Issue 12226026: [ChromeDriver] Select the main frame if a non-existant child frame is targeted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: watch for message and make test non-racey Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/run_py_tests.py
diff --git a/chrome/test/chromedriver/run_py_tests.py b/chrome/test/chromedriver/run_py_tests.py
index 88ac936c5005e2ff57389ed42ec70bf1def8f06f..c45dc6192bec0a33e1b7599158f08d0d3eec767e 100755
--- a/chrome/test/chromedriver/run_py_tests.py
+++ b/chrome/test/chromedriver/run_py_tests.py
@@ -9,6 +9,7 @@ import ctypes
import optparse
import os
import sys
+import time
kkania 2013/02/06 23:45:26 x
craigdh 2013/02/07 00:05:37 Done.
import unittest
import chromedriver
@@ -84,6 +85,20 @@ class ChromeDriverTest(unittest.TestCase):
self._driver.SwitchToFrameByIndex(0)
self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
+ def testExecuteInRemovedFrame(self):
+ self._driver.ExecuteScript(
+ 'var frame = document.createElement("iframe");'
+ 'frame.id="id";'
+ 'frame.name="name";'
+ 'document.body.appendChild(frame);'
+ 'window.addEventListener("message",'
+ ' function(event) { document.body.removeChild(frame); });')
+ self.assertTrue(self._driver.ExecuteScript('return window.top == window'))
+ self._driver.SwitchToFrame('id')
+ self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
+ self._driver.ExecuteScript('parent.postMessage("remove", "*");')
+ self.assertTrue(self._driver.ExecuteScript('return window.top == window'))
+
def testGetTitle(self):
script = 'document.title = "title"; return 1;'
self.assertEquals(1, self._driver.ExecuteScript(script))

Powered by Google App Engine
This is Rietveld 408576698