Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 12226026: [ChromeDriver] Select the main frame if a non-existant child frame is targeted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index 3779dc755b4438c946a2fcd6ca5022b29e6efaa7..f9ad36ab0c0c911c9abefb565f2b3715bd6b4e4c 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -11,12 +11,12 @@
#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "base/values.h"
-#include "chrome/test/chromedriver/chrome.h"
#include "chrome/test/chromedriver/chrome_launcher.h"
#include "chrome/test/chromedriver/command_executor_impl.h"
#include "chrome/test/chromedriver/commands.h"
#include "chrome/test/chromedriver/fake_session_accessor.h"
#include "chrome/test/chromedriver/status.h"
+#include "chrome/test/chromedriver/stub_chrome.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/webdriver/atoms.h"
@@ -36,55 +36,6 @@ TEST(CommandsTest, GetStatus) {
namespace {
-class StubChrome : public Chrome {
- public:
- StubChrome() {}
- virtual ~StubChrome() {}
-
- // Overridden from Chrome:
- virtual Status Load(const std::string& url) OVERRIDE {
- return Status(kOk);
- }
- virtual Status Reload() OVERRIDE {
- return Status(kOk);
- }
- virtual Status EvaluateScript(const std::string& frame,
- const std::string& function,
- scoped_ptr<base::Value>* result) OVERRIDE {
- return Status(kOk);
- }
- virtual Status CallFunction(const std::string& frame,
- const std::string& function,
- const base::ListValue& args,
- scoped_ptr<base::Value>* result) OVERRIDE {
- return Status(kOk);
- }
- virtual Status GetFrameByFunction(const std::string& frame,
- const std::string& function,
- const base::ListValue& args,
- std::string* out_frame) OVERRIDE {
- return Status(kOk);
- }
- virtual Status DispatchMouseEvents(
- const std::list<MouseEvent>& events) OVERRIDE {
- return Status(kOk);
- }
- virtual Status DispatchKeyEvents(const std::list<KeyEvent>& events) OVERRIDE {
- return Status(kOk);
- }
- virtual Status Quit() OVERRIDE {
- return Status(kOk);
- }
- virtual Status WaitForPendingNavigations(
- const std::string& frame_id) OVERRIDE {
- return Status(kOk);
- }
- virtual Status GetMainFrame(
- std::string* frame_id) OVERRIDE {
- return Status(kOk);
- }
-};
-
class OkChrome : public StubChrome {
public:
OkChrome() {}

Powered by Google App Engine
This is Rietveld 408576698