[ChromeDriver] Select the main frame if a non-existant child frame is targeted.

chrome/test/chromedriver/run_py_tests.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """End to end tests for ChromeDriver."""
 
 import ctypes
 import optparse
 import os
 import sys
+import time
 import unittest
 
 import chromedriver
 import webserver
 from webelement import WebElement
 
 _THIS_DIR = os.path.abspath(os.path.dirname(__file__))
 sys.path.insert(0, os.path.join(_THIS_DIR, os.pardir, 'pylib'))
 
 from common import chrome_paths
@@ skipping 55 matching lines @@
     self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
     self._driver.SwitchToMainFrame()
     self.assertTrue(self._driver.ExecuteScript('return window.top == window'))
     self._driver.SwitchToFrame('name')
     self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
     self._driver.SwitchToMainFrame()
     self.assertTrue(self._driver.ExecuteScript('return window.top == window'))
     self._driver.SwitchToFrameByIndex(0)
     self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
 
+  def testExecuteInRemovedFrame(self):
+    self._driver.ExecuteScript(
+        'var frame = document.createElement("iframe");'
+        'frame.id="id";'
+        'frame.name="name";'
+        'document.body.appendChild(frame);')
+    self.assertTrue(self._driver.ExecuteScript('return window.top == window'))
+    self._driver.SwitchToFrame('id')
+    self.assertTrue(self._driver.ExecuteScript('return window.top != window'))
+    self._driver.SwitchToMainFrame()
+    self._driver.ExecuteScript(
+        'var frame = document.getElementById("id");'
+        'window.setTimeout(function() {'
+        '    document.body.removeChild(frame);'
+        '}, 1000);')

[kkania, 2013/02/06 01:41:25]

is there a non racy way to do this?

[craigdh, 2013/02/06 18:52:49]

Yeah, just realized I can probably do it with a postMessage() across the frame
boundary.

+    self._driver.SwitchToFrame('id')
+
+    def _BecomesTrue(func, sec):
+      timeout = time.time() + sec
+      while time.time() < timeout:
+        if func():
+          return True
+        time.sleep(0.01)
+      return False
+
+    self.assertTrue(_BecomesTrue(
+        lambda: self._driver.ExecuteScript('return window.top == window'), 5))

[chrisgao (Use stgao instead), 2013/02/06 01:32:14]

Are 5 seconds long enough if the bot is in heavy load? I suggest to make it a
little longer.

[craigdh, 2013/02/06 18:52:49]

Done.

+
   def testGetTitle(self):
     script = 'document.title = "title"; return 1;'
     self.assertEquals(1, self._driver.ExecuteScript(script))
     self.assertEquals('title', self._driver.GetTitle())
 
   def testFindElement(self):
     self._driver.ExecuteScript(
         'document.body.innerHTML = "<div>a</div><div>b</div>";')
     self.assertTrue(
         isinstance(self._driver.FindElement('tag name', 'div'), WebElement))
@@ skipping 173 matching lines @@
   else:
     _CHROME_BINARY = None
 
   all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule(
       sys.modules[__name__])
   tests = unittest_util.FilterTestSuite(all_tests_suite, options.filter)
   ChromeDriverTest.GlobalSetUp();
   result = unittest.TextTestRunner().run(tests)
   ChromeDriverTest.GlobalTearDown();
   sys.exit(len(result.failures) + len(result.errors))