[ChromeDriver] Select the main frame if a non-existant child frame is targeted.

chrome/test/chromedriver/devtools_client_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_CHROMEDRIVER_DEVTOOLS_CLIENT_IMPL_H_
 #define CHROME_TEST_CHROMEDRIVER_DEVTOOLS_CLIENT_IMPL_H_
 
 #include <list>
 #include <map>
 #include <string>
@@ skipping 10 matching lines @@
 class DictionaryValue;
 }
 
 namespace internal {
 
 enum InspectorMessageType {
   kEventMessageType = 0,
   kCommandResponseMessageType
 };
 
+enum InspectorErrorCode {
+  kContextIdNotFound = -32000,

[kkania, 2013/02/06 01:41:25]

-32000 just means generic server error.  devtools doesn't have very specific
error codes.  Here's our options:

1) add error codes
This will take a bit of work and you should probably consult with the devtools
guys first.  It might be hard to make this in before next week's branch.

2) compare message strings instead of the codes
This is a bit hacky, but probably fairly stable.  I think this one is "Execution
context with given id not found."  You can look at the webkit history to see if
this has ever changed.  If they do happen to change in the future, we can just
map multiple messages to the same error.  I think eventually we should fix this
though...

3) after receiving a generic error, check and see if the frame is detached; if
so, report error
This should work, but it doesn't seem that clean to me either.  This assumes
we'll receive the detach message before the command response, which probably
works now.

WHat do you think?

[craigdh, 2013/02/06 18:52:49]

Ah, that's unfortunate. I think for now the best choice is probably (2) as a
one-off, but we should reevaluate (1) if we find ourselves needing to watch for
more devtools errors in the future. I'm also not a big fan of (3), it seems
unnecessarily messy.

+};
+
 struct InspectorEvent {
   InspectorEvent();
   ~InspectorEvent();
   std::string method;
   scoped_ptr<base::DictionaryValue> params;
 };
 
 struct InspectorCommandResponse {
   InspectorCommandResponse();
   ~InspectorCommandResponse();
@@ skipping 70 matching lines @@
 bool ParseInspectorMessage(
     const std::string& message,
     int expected_id,
     InspectorMessageType* type,
     InspectorEvent* event,
     InspectorCommandResponse* command_response);
 
 }  // namespace internal
 
 #endif  // CHROME_TEST_CHROMEDRIVER_DEVTOOLS_CLIENT_IMPL_H_