Add a git command for running ToT WebKit patches against the trybots.

Add a git command for running ToT WebKit patches against the trybots.

This is basically a wrapper script for running a WebKit change against
the try bots.  It can be run from within third_party/WebKit and will try to apply the patch against ToT WebKit.

This tells the try server we want to use ToT WebKit by passing third_party/WebKit@HEAD as the first line of the patch file.

BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181972

[Dirk Pranke, 2013-02-05 20:02:34]

Can't you get this with just either git-try from within a webkit directory or
with git-try -s third_party/WebKit@revision?

I'm pretty sure that at least used to work, and if something like that works but
we just want better sugar either we should fix that or write a smaller wrapper
around git-try rather than wrapping trychange directly, I think.

[tony, 2013-02-05 20:29:26]

On 2013/02/05 20:02:34, Dirk Pranke wrote:
> Can't you get this with just either git-try from within a webkit directory or
> with git-try -s third_party/WebKit@revision?

If you run it from within third_party/WebKit, you won't get WebKit ToT since
there's no DEPS file change.  If you run this with -s ..., you need to still
manually change DEPS to point to WebKit ToT, which is a pain.

> I'm pretty sure that at least used to work, and if something like that works
but
> we just want better sugar either we should fix that or write a smaller wrapper
> around git-try rather than wrapping trychange directly, I think.

It works with command line flags, but using -s and having to specify the layout
bots and change DEPS seems like enough busy work that we should make it work
better.

Oh, it also tries to avoid failure to apply the DEPS change by using the same
chromium revision that the user has.

[cmp, 2013-02-05 20:45:08]

+szager for review

[jochen (gone - plz use gerrit), 2013-02-06 21:06:17]

did you try that in a submodules checkout? git try --sub_rep fails for me

[tony, 2013-02-06 21:23:51]

On 2013/02/06 21:06:17, jochen wrote:
> did you try that in a submodules checkout? git try --sub_rep fails for me

I am using a submodules checkout.  This effectively runs:
  git try --sub_rep third_party/WebKit --root src -b
linux_layout_rel,mac_layout_rel,win_layout_rel 

from src/.  It also requires that changes in WebKit are committed (that's how
git-try works).

[jochen (gone - plz use gerrit), 2013-02-06 21:28:44]

strange, for me this doesn't work, it says

Could not guess version control system for /chrome/trunk/src/third_party/WebKit.
Are you in a working copy directory?
Sorry, Tryserver is not available.

[Dirk Pranke, 2013-02-07 03:38:01]

lgtm.

I think this basically looks right. As discussed previously, it seems like there
should be a set of existing arguments to git-try that would do the same thing,
but it's possible that they no longer work, or never worked in the submodule
config, or something. I haven't yet had the time to properly dig into that; I
hope to do so tomorrow, but I don't want to block this in the meantime (we can
always get rid of it or rewrite it if it turns out I'm right).

[M-A Ruel, 2013-02-07 14:06:17]

I know Stephen did send WebKit try jobs so he may have valuable feedback.

https://codereview.chromium.org/12226013/diff/5001/git-wktry
File git-wktry (right):

https://codereview.chromium.org/12226013/diff/5001/git-wktry#newcode2
git-wktry:2: # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2013 while at it

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py
File git_wktry.py (right):

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode2
git_wktry.py:2: # Copyright (c) 2011 The Chromium Authors. All rights reserved.
Same

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode23
git_wktry.py:23: _, self._path = tempfile.mkstemp(**kwargs)
you need to os.close() the initial argument otherwise it leaks. In particular on
Windows, the file is open with exclusive sharing so nobody will be able to use
it.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode47
git_wktry.py:47: def generateDiff(path_to_write, chromium_src_root):
Can you add a docstring just to explain that it's generating a diff against
something.

IMHO, it should generate a diff against $(git svn find-rev r%d) where %d is the
current webkit_revision in DEPS.

But I'm not a user so I don't mind.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode88
git_wktry.py:88: 
Two lines

[Stephen White, 2013-02-07 14:25:50]

On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> I know Stephen did send WebKit try jobs so he may have valuable feedback.

This looks good to me, as far as that goes.  I basically did things the way this
script does:  --sub_rep third_party/WebKit, and explicit --revision.


> 
> https://codereview.chromium.org/12226013/diff/5001/git-wktry
> File git-wktry (right):
> 
> https://codereview.chromium.org/12226013/diff/5001/git-wktry#newcode2
> git-wktry:2: # Copyright (c) 2011 The Chromium Authors. All rights reserved.
> 2013 while at it
> 
> https://codereview.chromium.org/12226013/diff/5001/git_wktry.py
> File git_wktry.py (right):
> 
> https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode2
> git_wktry.py:2: # Copyright (c) 2011 The Chromium Authors. All rights
reserved.
> Same
> 
> https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode23
> git_wktry.py:23: _, self._path = tempfile.mkstemp(**kwargs)
> you need to os.close() the initial argument otherwise it leaks. In particular
on
> Windows, the file is open with exclusive sharing so nobody will be able to use
> it.
> 
> https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode47
> git_wktry.py:47: def generateDiff(path_to_write, chromium_src_root):
> Can you add a docstring just to explain that it's generating a diff against
> something.
> 
> IMHO, it should generate a diff against $(git svn find-rev r%d) where %d is
the
> current webkit_revision in DEPS.
> 
> But I'm not a user so I don't mind.
> 
> https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode88
> git_wktry.py:88: 
> Two lines

[tony, 2013-02-11 20:52:46]

Please take another look.  I updated this change now that
https://codereview.chromium.org/12221058/ has landed.  We don't need to patch
src/DEPS or provide a chromium revision because the change is only to
third_party/WebKit.

https://codereview.chromium.org/12226013/diff/5001/git-wktry
File git-wktry (right):

https://codereview.chromium.org/12226013/diff/5001/git-wktry#newcode2
git-wktry:2: # Copyright (c) 2011 The Chromium Authors. All rights reserved.
On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> 2013 while at it

Done.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py
File git_wktry.py (right):

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode2
git_wktry.py:2: # Copyright (c) 2011 The Chromium Authors. All rights reserved.
On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> Same

Done.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode23
git_wktry.py:23: _, self._path = tempfile.mkstemp(**kwargs)
On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> you need to os.close() the initial argument otherwise it leaks. In particular
on
> Windows, the file is open with exclusive sharing so nobody will be able to use
> it.

Done.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode47
git_wktry.py:47: def generateDiff(path_to_write, chromium_src_root):
On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> Can you add a docstring just to explain that it's generating a diff against
> something.
> 
> IMHO, it should generate a diff against $(git svn find-rev r%d) where %d is
the
> current webkit_revision in DEPS.
> 
> But I'm not a user so I don't mind.

Done.

https://codereview.chromium.org/12226013/diff/5001/git_wktry.py#newcode88
git_wktry.py:88: 
On 2013/02/07 14:06:17, Marc-Antoine Ruel wrote:
> Two lines

Done.

[M-A Ruel, 2013-02-11 21:04:54]

lgtm

https://codereview.chromium.org/12226013/diff/11001/git_wktry.py
File git_wktry.py (right):

https://codereview.chromium.org/12226013/diff/11001/git_wktry.py#newcode82
git_wktry.py:82: swallow_exception=False, prog='git wktry')
align at +4