Teach build/symlink.py --force to delete directories.

build/symlink.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Make a symlink and optionally touch a file (to handle dependencies)."""

[Nico, 2015/07/01 18:27:34]

…actually, it looks like this is for build deps. Depending on a directory in
general won't do the right thing. What are you trying to do? What's this for?

 
 
 import errno
 import optparse
 import os.path
+import shutil
 import sys
 
 
 def Main(argv):
   parser = optparse.OptionParser()
   parser.add_option('-f', '--force', action='store_true')
   parser.add_option('--touch')
 
   options, args = parser.parse_args(argv[1:])
   if len(args) < 2:
     parser.error('at least two arguments required.')
 
   target = args[-1]
   sources = args[:-1]
   for s in sources:
     t = os.path.join(target, os.path.basename(s))
     try:
       os.symlink(s, t)
     except OSError, e:
       if e.errno == errno.EEXIST and options.force:
-        os.remove(t)
+        if os.path.isdir(t):
+          shutil.rmtree(t, ignore_errors=True)

[Nico, 2015/07/01 18:26:43]

Do you need this to work on Windows? shutil.rmtree() fails on Windows if there
are read-only files in the directory. That's why many places do

  if win:
    shell out to rmdir /s/q
  else:
    shutil.rmtree

+        else:
+          os.remove(t)
         os.symlink(s, t)
       else:
         raise
 
 
   if options.touch:
     with open(options.touch, 'w') as f:
       pass
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))