Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1222563003: Revert of Added support for Time Elapsed queries through the command buffer. (Closed)

Created:
5 years, 5 months ago by amineer
Modified:
5 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, binji+watch_chromium.org, tzik, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, teravest+watch_chromium.org, yusukes+watch_chromium.org, raymes+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added support for Time Elapsed queries through the command buffer. (patchset #10 id:180001 of https://codereview.chromium.org/1188013004/) Reason for revert: May be causing crashes BUG=506120 Original issue's description: > Added support for Time Elapsed queries through the command buffer. > > This CL adds support for Time Elapsed queries through the command > buffer. > > Since it was easy to support, I have also added support > for getting the current TimeStamp through GetInteger64(), > GetInteger()...etc. Note that this is different from getting the > GPU timestamp using QueryCounter which is asynchronous. > > BUG=345227 > TEST=trybots > > Committed: https://crrev.com/1b6a2940fcb25df247b9f8b795e84e1ca5742904 > Cr-Commit-Position: refs/heads/master@{#336743} TBR=zmo@chromium.org,sievers@chromium.org,bbudge@chromium.org,kbr@chromium.org,bajones@chromium.org,michaeln@chromium.org,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=345227 Committed: https://crrev.com/6c3e20e4fccf530aea0f519532cc6a3a067051c5 Cr-Commit-Position: refs/heads/master@{#337108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -287 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 5 chunks +47 lines, -82 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +1 line, -16 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 5 chunks +17 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/query_manager.h View 3 chunks +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/query_manager.cc View 5 chunks +0 lines, -75 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/gl/gpu_timing.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gpu_timing.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/gl/gpu_timing_fake.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gpu_timing_fake.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
amineer
Created Revert of Added support for Time Elapsed queries through the command buffer.
5 years, 5 months ago (2015-07-01 20:28:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222563003/1
5 years, 5 months ago (2015-07-01 20:29:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 20:29:53 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 20:31:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c3e20e4fccf530aea0f519532cc6a3a067051c5
Cr-Commit-Position: refs/heads/master@{#337108}

Powered by Google App Engine
This is Rietveld 408576698