Issue 12225154: NaCl: Remove use of the C++ IMC interface; use the C version instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225154: NaCl: Remove use of the C++ IMC interface; use the C version instead (Closed)

Created:
7 years, 10 months ago by Mark Seaborn

Modified:
7 years, 10 months ago

Reviewers:
dmichael (off chromium), Petr Hosek

CC:
chromium-reviews, native-client-reviews_googlegroups.com, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Remove use of the C++ IMC interface; use the C version instead We want to remove the C++ version of IMC from the NaCl side. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3303 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182091

Patch Set 1 #

Patch Set 2 : Fix comments too #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -24 lines)			Patch
M	chrome/browser/nacl_host/nacl_process_host.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View		8 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/renderer/pepper/ppb_nacl_private_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/nacl_entry_points.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Petr Hosek

On 2013/02/13 00:23:08, Mark Seaborn wrote: LGTM if bots are happy

7 years, 10 months ago (2013-02-13 00:26:15 UTC) #2

lgtm

Expand Messages | Collapse Messages