Issue 12225135: [Cleanup] Files.app: add missing periods on comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225135: [Cleanup] Files.app: add missing periods on comments. (Closed)

Created:
7 years, 10 months ago by yoshiki

Modified:
7 years, 10 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Cleanup] Files.app: add missing periods on comments. All changes are in comments. This patch doesn't change any semantics. BUG=175657 TEST=none R=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181891

Patch Set 2 : comment fix #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	chrome/browser/resources/file_manager/js/default_action_dialog.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/directory_model.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager_pyauto.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_table.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/path_util.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/util.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mtomasz

lgtm with one comment. https://codereview.chromium.org/12225135/diff/1/chrome/browser/resources/file_manager/js/path_util.js File chrome/browser/resources/file_manager/js/path_util.js (right): https://codereview.chromium.org/12225135/diff/1/chrome/browser/resources/file_manager/js/path_util.js#newcode40 chrome/browser/resources/file_manager/js/path_util.js:40: * @return {Array.<string>} path components. ...

7 years, 10 months ago (2013-02-12 06:39:23 UTC) #2

yoshiki

7 years, 10 months ago (2013-02-12 06:42:45 UTC) #3

https://codereview.chromium.org/12225135/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/path_util.js (right):

https://codereview.chromium.org/12225135/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/path_util.js:40: * @return
{Array.<string>} path components.
Good catch! Done.

On 2013/02/12 06:39:23, mtomasz wrote:
> First letter upper case?

Expand Messages | Collapse Messages

Issue 12225135: [Cleanup] Files.app: add missing periods on comments. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment fix #

Messages