Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: utils/pub/system_cache.dart

Issue 12225085: Make createTempDir() synchronous. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library system_cache; 5 library system_cache;
6 6
7 import 'dart:io'; 7 import 'dart:io';
8 import 'dart:async'; 8 import 'dart:async';
9 9
10 import 'git_source.dart'; 10 import 'git_source.dart';
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 .whenComplete(() { _pendingInstalls.remove(id); }); 94 .whenComplete(() { _pendingInstalls.remove(id); });
95 _pendingInstalls[id] = future; 95 _pendingInstalls[id] = future;
96 return future; 96 return future;
97 } 97 }
98 98
99 /// Create a new temporary directory within the system cache. The system 99 /// Create a new temporary directory within the system cache. The system
100 /// cache maintains its own temporary directory that it uses to stage 100 /// cache maintains its own temporary directory that it uses to stage
101 /// packages into while installing. It uses this instead of the OS's system 101 /// packages into while installing. It uses this instead of the OS's system
102 /// temp directory to ensure that it's on the same volume as the pub system 102 /// temp directory to ensure that it's on the same volume as the pub system
103 /// cache so that it can move the directory from it. 103 /// cache so that it can move the directory from it.
104 Future<Directory> createTempDir() { 104 Directory createTempDir() {
105 return defer(() { 105 var temp = ensureDir(tempDir);
106 var temp = ensureDir(tempDir); 106 return io.createTempDir(join(temp, 'dir'));
107 return io.createTempDir(join(temp, 'dir'));
108 });
109 } 107 }
110 108
111 /// Delete's the system cache's internal temp directory. 109 /// Delete's the system cache's internal temp directory.
112 Future deleteTempDir() { 110 Future deleteTempDir() {
113 log.fine('Clean up system cache temp directory $tempDir.'); 111 log.fine('Clean up system cache temp directory $tempDir.');
114 return defer(() { 112 return defer(() {
115 if (!dirExists(tempDir)) return; 113 if (!dirExists(tempDir)) return;
116 return deleteDir(tempDir); 114 return deleteDir(tempDir);
117 }); 115 });
118 } 116 }
119 } 117 }
OLDNEW
« no previous file with comments | « utils/pub/io.dart ('k') | utils/tests/pub/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698