Delete most web intents code.

Delete most web intents code.

It's already disabled, so this should have no observable effect.

The database code stays around until I've written a migration to delete the
webintents table.

The apps schema code stays around so that 'intent' blocks in apps are
silently ignored instead of causing an error.

BUG=173194
TBR=piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181702

[Nico, 2013-02-07 05:25:36]

One question about apps apis below:

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.h (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:53: class
AppRuntimePostIntentResponseFunction : public SyncExtensionFunction {
This is still here because as far as I understand it's needed to silently ignore
"intent" sections in the manifest. Is this correct?

[benwells, 2013-02-07 06:00:02]

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.h (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:30: // Dispatches
the onLaunched event to the given app, providing launch data of
Please add a TODO here on me to update this comment, it is out of date.

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:53: class
AppRuntimePostIntentResponseFunction : public SyncExtensionFunction {
On 2013/02/07 05:25:36, Nico wrote:
> This is still here because as far as I understand it's needed to silently
ignore
> "intent" sections in the manifest. Is this correct?

I don't think so, it should be removed.

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/platform_app_launcher.cc:170: if (!found_service) {
nit: this can become if (!handler), with found_service removed.

[Nico, 2013-02-07 06:20:23]

Thanks!

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.h (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:30: // Dispatches
the onLaunched event to the given app, providing launch data of
On 2013/02/07 06:00:03, benwells wrote:
> Please add a TODO here on me to update this comment, it is out of date.

Done.

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:53: class
AppRuntimePostIntentResponseFunction : public SyncExtensionFunction {
On 2013/02/07 06:00:03, benwells wrote:
> On 2013/02/07 05:25:36, Nico wrote:
> > This is still here because as far as I understand it's needed to silently
> ignore
> > "intent" sections in the manifest. Is this correct?
> 
> I don't think so, it should be removed.

If I delete the class, I get this error:

  gen/chrome/common/extensions/api/generated_api.h:308:32: error: use of
undeclared identifier 'AppRuntimePostIntentResponseFunction'

Should I delete postIntentResponse() from
chrome/common/extensions/api/app_runtime.idl ? Does this not break apps apis?

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/platform_app_launcher.cc:170: if (!found_service) {
On 2013/02/07 06:00:03, benwells wrote:
> nit: this can become if (!handler), with found_service removed.

Done.

[benwells, 2013-02-07 06:44:53]

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.h (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:53: class
AppRuntimePostIntentResponseFunction : public SyncExtensionFunction {
On 2013/02/07 06:20:23, Nico wrote:
> On 2013/02/07 06:00:03, benwells wrote:
> > On 2013/02/07 05:25:36, Nico wrote:
> > > This is still here because as far as I understand it's needed to silently
> > ignore
> > > "intent" sections in the manifest. Is this correct?
> > 
> > I don't think so, it should be removed.
> 
> If I delete the class, I get this error:
> 
>   gen/chrome/common/extensions/api/generated_api.h:308:32: error: use of
> undeclared identifier 'AppRuntimePostIntentResponseFunction'
> 
> Should I delete postIntentResponse() from
> chrome/common/extensions/api/app_runtime.idl ? Does this not break apps apis?

Yes you should delete that and the other intent stuff from the IDL. These apis
are new and platform apps are not yet publicly released, so we still have room
to remove these APIs.

[Nico, 2013-02-08 22:42:54]

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
File chrome/browser/extensions/api/app_runtime/app_runtime_api.h (right):

https://codereview.chromium.org/12225076/diff/2016/chrome/browser/extensions/...
chrome/browser/extensions/api/app_runtime/app_runtime_api.h:53: class
AppRuntimePostIntentResponseFunction : public SyncExtensionFunction {
On 2013/02/07 06:44:53, benwells wrote:
> On 2013/02/07 06:20:23, Nico wrote:
> > On 2013/02/07 06:00:03, benwells wrote:
> > > On 2013/02/07 05:25:36, Nico wrote:
> > > > This is still here because as far as I understand it's needed to
silently
> > > ignore
> > > > "intent" sections in the manifest. Is this correct?
> > > 
> > > I don't think so, it should be removed.
> > 
> > If I delete the class, I get this error:
> > 
> >   gen/chrome/common/extensions/api/generated_api.h:308:32: error: use of
> > undeclared identifier 'AppRuntimePostIntentResponseFunction'
> > 
> > Should I delete postIntentResponse() from
> > chrome/common/extensions/api/app_runtime.idl ? Does this not break apps
apis?
> 
> Yes you should delete that and the other intent stuff from the IDL. These apis
> are new and platform apps are not yet publicly released, so we still have room
> to remove these APIs.

Done.

[benwells, 2013-02-11 08:04:44]

chrome/browser/chromeos/extensions
chrome/browser/extensions
chrome/browser/ui/extensions
chrome/common/extensions

all lgtm, with a couple of baby nits and the onLaunched event undeprecated.

https://codereview.chromium.org/12225076/diff/1151/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://codereview.chromium.org/12225076/diff/1151/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:1064: // Take the
union of platform app file handlers,  and all previous Drive
Tiny nit: double space.

https://codereview.chromium.org/12225076/diff/1151/chrome/common/extensions/a...
File chrome/common/extensions/api/app_runtime.idl (right):

https://codereview.chromium.org/12225076/diff/1151/chrome/common/extensions/a...
chrome/common/extensions/api/app_runtime.idl:7: callback NullCallback = void ();
Nit: NullCallback is not needed anymore.

https://codereview.chromium.org/12225076/diff/1151/chrome/common/extensions/a...
chrome/common/extensions/api/app_runtime.idl:26: // Fired when an app is
launched from the launcher. Deprecated.
This is still used :) Please don't make it deprecated or nodoc! (sorry I should
have noticed that in the last patch).

[Nico, 2013-02-11 15:16:12]

Thanks!

jochen: chrome/ except
chrome/browser/chromeos/extensions
chrome/browser/extensions
chrome/browser/ui/extensions
chrome/common/extensions
(which benwells looked at already).

piman: content/

All changes in the files you're looking at should be completely mechanical and
should consist only of removal of #if defined(ENABLE_WEB_INTENTS) blocks.

https://codereview.chromium.org/12225076/diff/1151/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://codereview.chromium.org/12225076/diff/1151/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:1064: // Take the
union of platform app file handlers,  and all previous Drive
On 2013/02/11 08:04:44, benwells wrote:
> Tiny nit: double space.

Done.

https://codereview.chromium.org/12225076/diff/1151/chrome/common/extensions/a...
File chrome/common/extensions/api/app_runtime.idl (right):

https://codereview.chromium.org/12225076/diff/1151/chrome/common/extensions/a...
chrome/common/extensions/api/app_runtime.idl:7: callback NullCallback = void ();
On 2013/02/11 08:04:44, benwells wrote:
> Nit: NullCallback is not needed anymore.

Done.

[jochen (gone - plz use gerrit), 2013-02-11 15:24:45]

lgtm

[commit-bot: I haz the power, 2013-02-11 15:40:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/12225076/11002