[cros] Set profile pref for locally managed users

chrome/browser/profiles/profile_manager.cc

Index: chrome/browser/profiles/profile_manager.cc
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
index d35f18603f106b0968c2817e8e3a6d3f2925f976..8948811d363bb2cbbe9882805605b65749ccf6c8 100644
--- a/chrome/browser/profiles/profile_manager.cc
+++ b/chrome/browser/profiles/profile_manager.cc
@@ -466,7 +466,8 @@ void ProfileManager::CreateProfileAsync(
 }
 
 // static
-void ProfileManager::CreateDefaultProfileAsync(const CreateCallback& callback) {
+void ProfileManager::CreateDefaultProfileAsync(const CreateCallback& callback,
+                                               bool is_managed) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 
@@ -475,8 +476,12 @@ void ProfileManager::CreateDefaultProfileAsync(const CreateCallback& callback) {
   default_profile_dir = default_profile_dir.Append(
       profile_manager->GetInitialProfileDir());
 
+  // Chrome OS specific note: since we pass string16() here as the icon_url,

[Dmitry Polukhin, 2013/02/08 17:26:53]

Why do we need this change in this case??? If all real things happen in
CREATE_STATUS_CREATED notification, can we remove this code?

[Nikita (slow), 2013/02/08 21:55:05]

I agree that we could always pass false here for |is_managed| as we do for other
parameters and I will leave this comment because it summarizes the difference
between multi-profile handling (profile cache structure) on CrOS.

[rpetterson, 2013/02/08 22:37:56]

nit: The comment could be a bit clearer: which property will get initialized in
the Profile::CREATE_STATUS_CREATED callback? The icon_url or the is_managed
value?

Otherwise, LGTM for profiles.

[Nikita (slow), 2013/02/11 09:42:12]

Done.

+  // profile cache information will not get updated with the is_managed value.
+  // But on Chrome OS this property will get initialized in
+  // Profile::CREATE_STATUS_CREATED callback.
   profile_manager->CreateProfileAsync(
-      default_profile_dir, callback, string16(), string16(), false);
+      default_profile_dir, callback, string16(), string16(), is_managed);
 }
 
 bool ProfileManager::AddProfile(Profile* profile) {