[cros] Set profile pref for locally managed users

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 448 matching lines @@
     if (cache.IsDefaultAvatarIconUrl(icon_url_std, &icon_index)) {
       // add profile to cache with user selected name and avatar
       cache.AddProfileToCache(profile_path, name, string16(), icon_index,
                               is_managed);
     }
     info->callbacks.push_back(callback);
   }
 }
 
 // static
-void ProfileManager::CreateDefaultProfileAsync(const CreateCallback& callback) {
+void ProfileManager::CreateDefaultProfileAsync(const CreateCallback& callback,
+                                               bool is_managed) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 
   FilePath default_profile_dir = profile_manager->user_data_dir_;
   // TODO(mirandac): current directory will not always be default in the future
   default_profile_dir = default_profile_dir.Append(
       profile_manager->GetInitialProfileDir());
 
+  // Chrome OS specific note: since we pass string16() here as the icon_url,

[Dmitry Polukhin, 2013/02/08 17:26:53]

Why do we need this change in this case??? If all real things happen in
CREATE_STATUS_CREATED notification, can we remove this code?

[Nikita (slow), 2013/02/08 21:55:05]

I agree that we could always pass false here for |is_managed| as we do for other
parameters and I will leave this comment because it summarizes the difference
between multi-profile handling (profile cache structure) on CrOS.

[rpetterson, 2013/02/08 22:37:56]

nit: The comment could be a bit clearer: which property will get initialized in
the Profile::CREATE_STATUS_CREATED callback? The icon_url or the is_managed
value?

Otherwise, LGTM for profiles.

[Nikita (slow), 2013/02/11 09:42:12]

Done.

+  // profile cache information will not get updated with the is_managed value.
+  // But on Chrome OS this property will get initialized in
+  // Profile::CREATE_STATUS_CREATED callback.
   profile_manager->CreateProfileAsync(
-      default_profile_dir, callback, string16(), string16(), false);
+      default_profile_dir, callback, string16(), string16(), is_managed);
 }
 
 bool ProfileManager::AddProfile(Profile* profile) {
   DCHECK(profile);
 
   // Make sure that we're not loading a profile with the same ID as a profile
   // that's already loaded.
   if (GetProfileByPath(profile->GetPath())) {
     NOTREACHED() << "Attempted to add profile with the same path (" <<
                     profile->GetPath().value() <<
@@ skipping 602 matching lines @@
 ProfileManager::ProfileInfo::ProfileInfo(
     Profile* profile,
     bool created)
     : profile(profile),
       created(created) {
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
   ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }