Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: ui/views/focus/focus_traversal_unittest.cc

Issue 12225042: Remove NativeTabbedPane[Win|Wrapper]; promote Views impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rewrite a good portion of TabbedPane. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/focus/focus_traversal_unittest.cc
diff --git a/ui/views/focus/focus_traversal_unittest.cc b/ui/views/focus/focus_traversal_unittest.cc
index c110b21f266ab2ccd7f178a910f3cb175d9fd679..3faa7dd9cb69d52d87492c104137c749be4251e6 100644
--- a/ui/views/focus/focus_traversal_unittest.cc
+++ b/ui/views/focus/focus_traversal_unittest.cc
@@ -15,15 +15,12 @@
#include "ui/views/controls/link.h"
#include "ui/views/controls/native/native_view_host.h"
#include "ui/views/controls/scroll_view.h"
+#include "ui/views/controls/tabbed_pane/tabbed_pane.h"
#include "ui/views/controls/textfield/textfield.h"
#include "ui/views/focus/focus_manager_test.h"
#include "ui/views/widget/root_view.h"
#include "ui/views/widget/widget.h"
-#if !defined(USE_AURA)
-#include "ui/views/controls/tabbed_pane/tabbed_pane.h"
-#endif
-
namespace views {
namespace {
@@ -68,14 +65,12 @@ const int kOKButtonID = count++;
const int kCancelButtonID = count++;
const int kHelpButtonID = count++;
-#if !defined(USE_AURA)
const int kStyleContainerID = count++; // 35
const int kBoldCheckBoxID = count++;
const int kItalicCheckBoxID = count++;
const int kUnderlinedCheckBoxID = count++;
const int kStyleHelpLinkID = count++;
const int kStyleTextEditID = count++; // 40
-#endif
const int kSearchContainerID = count++;
const int kSearchTextfieldID = count++;
@@ -197,10 +192,8 @@ class FocusTraversalTest : public FocusManagerTest {
View* view = GetContentsView()->GetViewByID(id);
if (view)
return view;
-#if !defined(USE_AURA)
if (style_tab_)
view = style_tab_->GetSelectedTab()->GetViewByID(id);
-#endif
if (view)
return view;
view = search_border_view_->GetContentsRootView()->GetViewByID(id);
@@ -210,9 +203,7 @@ class FocusTraversalTest : public FocusManagerTest {
}
protected:
-#if !defined(USE_AURA)
TabbedPane* style_tab_;
-#endif
BorderView* search_border_view_;
DummyComboboxModel combobox_model_;
PaneView* left_container_;
@@ -222,10 +213,7 @@ class FocusTraversalTest : public FocusManagerTest {
};
FocusTraversalTest::FocusTraversalTest()
- :
-#if !defined(USE_AURA)
- style_tab_(NULL),
-#endif
+ : style_tab_(NULL),
search_border_view_(NULL) {
}
@@ -274,7 +262,6 @@ void FocusTraversalTest::InitContentView() {
// NativeButton * kOKButtonID
// NativeButton * kCancelButtonID
// NativeButton * kHelpButtonID
- // #if !defined(USE_AURA)
// TabbedPane * kStyleContainerID
// View
// Checkbox * kBoldCheckBoxID
@@ -283,7 +270,6 @@ void FocusTraversalTest::InitContentView() {
// Link * kStyleHelpLinkID
// Textfield * kStyleTextEditID
// Other
- // #endif
// BorderView kSearchContainerID
// View
// Textfield * kSearchTextfieldID
@@ -487,7 +473,6 @@ void FocusTraversalTest::InitContentView() {
View* contents = NULL;
Link* link = NULL;
-#if !defined(USE_AURA)
// Left bottom box with style checkboxes.
contents = new View();
contents->set_background(Background::CreateSolidBackground(SK_ColorWHITE));
@@ -522,7 +507,6 @@ void FocusTraversalTest::InitContentView() {
style_tab_->SetBounds(10, y, 210, 100);
style_tab_->AddTab(ASCIIToUTF16("Style"), contents);
style_tab_->AddTab(ASCIIToUTF16("Other"), new View());
-#endif
// Right bottom box with search.
contents = new View();
@@ -579,10 +563,8 @@ TEST_F(FocusTraversalTest, NormalTraversal) {
kDinerGameLinkID, kRidiculeLinkID, kClosetLinkID, kVisitingLinkID,
kAmelieLinkID, kJoyeuxNoelLinkID, kCampingLinkID, kBriceDeNiceLinkID,
kTaxiLinkID, kAsterixLinkID, kOKButtonID, kCancelButtonID, kHelpButtonID,
-#if !defined(USE_AURA)
kStyleContainerID, kBoldCheckBoxID, kItalicCheckBoxID,
kUnderlinedCheckBoxID, kStyleHelpLinkID, kStyleTextEditID,
-#endif
kSearchTextfieldID, kSearchButtonID, kHelpLinkID,
kThumbnailContainerID, kThumbnailStarID, kThumbnailSuperStarID };
@@ -620,21 +602,15 @@ TEST_F(FocusTraversalTest, TraversalWithNonEnabledViews) {
const int kDisabledIDs[] = {
kBananaTextfieldID, kFruitCheckBoxID, kComboboxID, kAsparagusButtonID,
kCauliflowerButtonID, kClosetLinkID, kVisitingLinkID, kBriceDeNiceLinkID,
- kTaxiLinkID, kAsterixLinkID, kHelpButtonID,
-#if !defined(USE_AURA)
- kBoldCheckBoxID,
-#endif
+ kTaxiLinkID, kAsterixLinkID, kHelpButtonID, kBoldCheckBoxID,
kSearchTextfieldID, kHelpLinkID };
const int kTraversalIDs[] = { kTopCheckBoxID, kAppleTextfieldID,
kOrangeTextfieldID, kKiwiTextfieldID, kFruitButtonID, kBroccoliButtonID,
kRosettaLinkID, kStupeurEtTremblementLinkID, kDinerGameLinkID,
kRidiculeLinkID, kAmelieLinkID, kJoyeuxNoelLinkID, kCampingLinkID,
- kOKButtonID, kCancelButtonID,
-#if !defined(USE_AURA)
- kStyleContainerID, kItalicCheckBoxID, kUnderlinedCheckBoxID,
- kStyleHelpLinkID, kStyleTextEditID,
-#endif
+ kOKButtonID, kCancelButtonID, kStyleContainerID, kItalicCheckBoxID,
+ kUnderlinedCheckBoxID, kStyleHelpLinkID, kStyleTextEditID,
kSearchButtonID, kThumbnailContainerID, kThumbnailStarID,
kThumbnailSuperStarID };
@@ -685,12 +661,9 @@ TEST_F(FocusTraversalTest, TraversalWithInvisibleViews) {
kStupeurEtTremblementLinkID, kDinerGameLinkID, kRidiculeLinkID,
kClosetLinkID, kVisitingLinkID, kAmelieLinkID, kJoyeuxNoelLinkID,
kCampingLinkID, kBriceDeNiceLinkID, kTaxiLinkID, kAsterixLinkID,
- kCancelButtonID, kHelpButtonID,
-#if !defined(USE_AURA)
- kStyleContainerID, kBoldCheckBoxID, kItalicCheckBoxID,
- kUnderlinedCheckBoxID, kStyleHelpLinkID, kStyleTextEditID,
-#endif
- kSearchTextfieldID, kSearchButtonID, kHelpLinkID };
+ kCancelButtonID, kHelpButtonID, kStyleContainerID, kBoldCheckBoxID,
+ kItalicCheckBoxID, kUnderlinedCheckBoxID, kStyleHelpLinkID,
+ kStyleTextEditID, kSearchTextfieldID, kSearchButtonID, kHelpLinkID };
// Let's make some views invisible.

Powered by Google App Engine
This is Rietveld 408576698