Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.

Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.

Remove NativeTabbedPaneWin and NativeTabbedPaneWrapper.
( its last use was eliminated in http://crrev.com/180924 )
Write a TabbedPane based on NativeTabbedPaneViews.
Update unit tests; cleanup; etc.

BUG=138059
TEST=No observable tabbed pane appearance/behavior changes (see the WebsiteSettingsPopupView and CollectedCookiesView); unit tests.
R=markusheintz@chromium.org,sky@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181798

[msw, 2013-02-06 12:49:20]

Please take a look; thanks!
Ben: ui/views/focus/*, more if interested.
Markus and Scott: everything else.

[sky, 2013-02-06 17:29:55]

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:58: virtual gfx::Size
GetPreferredSize() OVERRIDE {
Be consistant, inline it all or none of it.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:147: void SelectTab(View* tab) {
This should take a Tab* and selected_tab_ should be a Tab*.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:170: return contents;
What if contents == selected_tab_ ?

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:225: tab_strip_->SelectTab(this);
Only does this if this contains the location in event.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
File ui/views/controls/tabbed_pane/tabbed_pane.h (right):

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.h:39: void TabSelectionChanged(View*
selected);
Cant this be implemented in terms of SelectTabAt?

[msw, 2013-02-07 00:29:36]

Please take another look; thanks! I was planning to keep changes minimal, but
took the comments as an opportunity to cleanup the implementation.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:58: virtual gfx::Size
GetPreferredSize() OVERRIDE {
On 2013/02/06 17:29:55, sky wrote:
> Be consistant, inline it all or none of it.

Done.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:147: void SelectTab(View* tab) {
On 2013/02/06 17:29:55, sky wrote:
> This should take a Tab* and selected_tab_ should be a Tab*.

Moot.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:170: return contents;
On 2013/02/06 17:29:55, sky wrote:
> What if contents == selected_tab_ ?

Moot.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.cc:225: tab_strip_->SelectTab(this);
On 2013/02/06 17:29:55, sky wrote:
> Only does this if this contains the location in event.

Done.

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
File ui/views/controls/tabbed_pane/tabbed_pane.h (right):

https://codereview.chromium.org/12225042/diff/2012/ui/views/controls/tabbed_p...
ui/views/controls/tabbed_pane/tabbed_pane.h:39: void TabSelectionChanged(View*
selected);
On 2013/02/06 17:29:55, sky wrote:
> Cant this be implemented in terms of SelectTabAt?

Moot.

[sky, 2013-02-11 16:26:36]

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
ui/views/controls/tabbed_pane/tabbed_pane.cc:288:
tab->contents()->SetVisible(true);
How does the previously selected tab get hidden?

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
File ui/views/controls/tabbed_pane/tabbed_pane.h (right):

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
ui/views/controls/tabbed_pane/tabbed_pane.h:50: // Selects |tab| if it is valid.
Document what |tab| is.

[msw, 2013-02-11 20:41:43]

Comments addressed; please take another look; thanks!

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
ui/views/controls/tabbed_pane/tabbed_pane.cc:288:
tab->contents()->SetVisible(true);
On 2013/02/11 16:26:36, sky wrote:
> How does the previously selected tab get hidden?

Tab::SetSelected(false) at line 283 hides the old content.
I removed this redundant line, since the SetSelected(true) above suffices.

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
File ui/views/controls/tabbed_pane/tabbed_pane.h (right):

https://codereview.chromium.org/12225042/diff/13001/ui/views/controls/tabbed_...
ui/views/controls/tabbed_pane/tabbed_pane.h:50: // Selects |tab| if it is valid.
On 2013/02/11 16:26:36, sky wrote:
> Document what |tab| is.

Done (and changed to take a Tab*).

[sky, 2013-02-11 21:56:32]

LGTM

[commit-bot: I haz the power, 2013-02-11 22:09:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/12225042/6032

[commit-bot: I haz the power, 2013-02-12 00:38:26]

Change committed as 181798

[msw, 2013-02-12 02:54:50]

I reverted this CL for leaks in http://crrev.com/181831
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heap...
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v...
Sorry for any inconvenience; I'll post a followup soon.

[msw, 2013-02-12 06:55:28]

Follow up CL: https://codereview.chromium.org/12211122/
I'll TBR and land that unless there's any additional feedback/comments.