Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1222503003: Sync XML-related interfaces with their specs, or lack thereof (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync XML-related interfaces with their specs, or lack thereof The inResult arguments in XPathEvaluator and XPathExpression are called just result in the spec, but that conflicts with other variables in the generated code, so leave that as it is. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198201

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/xml/DOMParser.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/xml/XMLSerializer.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/xml/XPathEvaluator.idl View 1 1 chunk +12 lines, -3 lines 0 comments Download
M Source/core/xml/XPathExpression.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/xml/XPathNSResolver.idl View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/xml/XPathResult.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/xml/XSLTProcessor.idl View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222503003/1
5 years, 5 months ago (2015-06-30 22:05:17 UTC) #2
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-06-30 22:14:05 UTC) #4
philipj_slow
PTAL
5 years, 5 months ago (2015-07-01 21:29:37 UTC) #6
Jens Widell
LGTM
5 years, 5 months ago (2015-07-02 05:26:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222503003/20001
5 years, 5 months ago (2015-07-02 08:36:36 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 09:43:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198201

Powered by Google App Engine
This is Rietveld 408576698