Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Unified Diff: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc

Issue 12225011: Change profile shortcut name format to "<username> - Chrome". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
===================================================================
--- chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc (revision 180445)
+++ chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc (working copy)
@@ -285,9 +285,12 @@
TEST_F(ProfileShortcutManagerTest, ShortcutFilename) {
const string16 kProfileName = L"Harry";
BrowserDistribution* distribution = GetDistribution();
- const string16 expected_name = kProfileName + L" - " +
- distribution->GetAppShortCutName() + installer::kLnkExt;
- EXPECT_EQ(expected_name,
+#if defined(GOOGLE_CHROME_BUILD)
sail 2013/02/05 20:30:43 I don't think this is a good idea. You should use
Alexei Svitkine (slow) 2013/02/05 20:56:00 Done.
+ const string16 expected_name = L"Harry - Chrome";
+#else
+ const string16 expected_name = L"Harry - Chromium";
+#endif
+ EXPECT_EQ(expected_name + installer::kLnkExt,
profiles::internal::GetShortcutFilenameForProfile(kProfileName,
distribution));
}

Powered by Google App Engine
This is Rietveld 408576698