Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1222453003: Fix adb_install_apk, broken by 9b3e716. (Closed)

Created:
5 years, 5 months ago by twifkak
Modified:
5 years, 5 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix adb_install_apk, broken by 9b3e716. In http://crrev.com/9b3e716, args.apk was renamed to args.apk_name, but a couple of exception handlers weren't updated to follow suit. This fixes them, so they report proper error messages along with upstream backtraces. BUG=498232 Committed: https://crrev.com/4582edfe2b138fd63645caddde198dc7fee9bd0a Cr-Commit-Position: refs/heads/master@{#337048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/adb_install_apk.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
twifkak
5 years, 5 months ago (2015-07-01 09:37:01 UTC) #2
jbudorick
lgtm
5 years, 5 months ago (2015-07-01 12:59:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1222453003/1
5 years, 5 months ago (2015-07-01 15:44:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 16:56:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 16:58:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4582edfe2b138fd63645caddde198dc7fee9bd0a
Cr-Commit-Position: refs/heads/master@{#337048}

Powered by Google App Engine
This is Rietveld 408576698