[ChromeDriver] Remove FrameTracker's dependency on DomTracker.

[ChromeDriver] Remove FrameTracker's dependency on DomTracker.

BUG=175000
TEST=run_all_tests.py


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181985

[kkania, 2013-02-12 01:37:19]

lgtm

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
File chrome/test/chromedriver/frame_tracker.cc (right):

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
chrome/test/chromedriver/frame_tracker.cc:71:
client_->SendCommand("DOM.getDocument", params);
I don't think you don't need to do this; DOM.documentUpdated will be sent
forever if we just call DOM.getDocument once.

[craigdh, 2013-02-12 01:41:22]

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
File chrome/test/chromedriver/frame_tracker.cc (right):

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
chrome/test/chromedriver/frame_tracker.cc:71:
client_->SendCommand("DOM.getDocument", params);
On 2013/02/12 01:37:19, kkania wrote:
> I don't think you don't need to do this; DOM.documentUpdated will be sent
> forever if we just call DOM.getDocument once.

We originally did that and it didn't work. http://crbug.com/172944

[kkania, 2013-02-12 02:11:53]

On 2013/02/12 01:41:22, craigdh wrote:
>
https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
> File chrome/test/chromedriver/frame_tracker.cc (right):
> 
>
https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
> chrome/test/chromedriver/frame_tracker.cc:71:
> client_->SendCommand("DOM.getDocument", params);
> On 2013/02/12 01:37:19, kkania wrote:
> > I don't think you don't need to do this; DOM.documentUpdated will be sent
> > forever if we just call DOM.getDocument once.
> 
> We originally did that and it didn't work. http://crbug.com/172944

We need to do DOM.documentUpdated for the dom_tracker, not this one.

[kkania, 2013-02-12 02:12:11]

On 2013/02/12 02:11:53, kkania wrote:
> On 2013/02/12 01:41:22, craigdh wrote:
> >
>
https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
> > File chrome/test/chromedriver/frame_tracker.cc (right):
> > 
> >
>
https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
> > chrome/test/chromedriver/frame_tracker.cc:71:
> > client_->SendCommand("DOM.getDocument", params);
> > On 2013/02/12 01:37:19, kkania wrote:
> > > I don't think you don't need to do this; DOM.documentUpdated will be sent
> > > forever if we just call DOM.getDocument once.
> > 
> > We originally did that and it didn't work. http://crbug.com/172944
> 
> We need to do DOM.documentUpdated for the dom_tracker, not this one.

Oops, I mean, we need to do DOM.getDocument each time for the dom_tracker, not
this one.

[craigdh, 2013-02-12 17:32:30]

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
File chrome/test/chromedriver/frame_tracker.cc (right):

https://codereview.chromium.org/12224116/diff/1/chrome/test/chromedriver/fram...
chrome/test/chromedriver/frame_tracker.cc:71:
client_->SendCommand("DOM.getDocument", params);
On 2013/02/12 01:41:22, craigdh wrote:
> On 2013/02/12 01:37:19, kkania wrote:
> > I don't think you don't need to do this; DOM.documentUpdated will be sent
> > forever if we just call DOM.getDocument once.
> 
> We originally did that and it didn't work. http://crbug.com/172944 

I understand what you mean now.

[commit-bot: I haz the power, 2013-02-12 17:34:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/12224116/7001

[commit-bot: I haz the power, 2013-02-12 19:58:46]

Change committed as 181985