Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: media/filters/pipeline_integration_test.cc

Issue 12224114: Guard against midstream audio configuration changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/pipeline_integration_test.cc
diff --git a/media/filters/pipeline_integration_test.cc b/media/filters/pipeline_integration_test.cc
index 3e2eb194121c2aa6335581d03e5a1b994d3155b2..97f0abedbf2c6a01e813c992381f8a05dc2676bd 100644
--- a/media/filters/pipeline_integration_test.cc
+++ b/media/filters/pipeline_integration_test.cc
@@ -660,6 +660,15 @@ TEST_F(PipelineIntegrationTest,
EXPECT_EQ(PIPELINE_ERROR_DECODE, WaitUntilEndedOrError());
source.Abort();
}
+
+// Verify files which change configuration mid-stream are failed gracefully.
scherkus (not reviewing) 2013/02/12 02:16:56 s/are failed gracefully/fail gracefully/
DaleCurtis 2013/02/12 02:41:24 Done.
+TEST_F(PipelineIntegrationTest, MidStreamConfigChangesFail) {
+ ASSERT_TRUE(Start(
+ GetTestDataFilePath("midstream_config_change.mp3"), PIPELINE_OK));
+ Play();
+ ASSERT_EQ(WaitUntilEndedOrError(), PIPELINE_ERROR_DECODE);
+}
+
#endif
TEST_F(PipelineIntegrationTest, BasicPlayback_16x9AspectRatio) {

Powered by Google App Engine
This is Rietveld 408576698