Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 12224090: Remove instructions properly (stack check elimination was leaving "dangling uses" around). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 772 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 // Verify that instructions that may have side-effects are followed 783 // Verify that instructions that may have side-effects are followed
784 // by a simulate instruction. 784 // by a simulate instruction.
785 if (HasObservableSideEffects() && !IsOsrEntry()) { 785 if (HasObservableSideEffects() && !IsOsrEntry()) {
786 ASSERT(next()->IsSimulate()); 786 ASSERT(next()->IsSimulate());
787 } 787 }
788 788
789 // Verify that instructions that can be eliminated by GVN have overridden 789 // Verify that instructions that can be eliminated by GVN have overridden
790 // HValue::DataEquals. The default implementation is UNREACHABLE. We 790 // HValue::DataEquals. The default implementation is UNREACHABLE. We
791 // don't actually care whether DataEquals returns true or false here. 791 // don't actually care whether DataEquals returns true or false here.
792 if (CheckFlag(kUseGVN)) DataEquals(this); 792 if (CheckFlag(kUseGVN)) DataEquals(this);
793
794 // Verify that all uses are in the graph.
795 for (HUseIterator use = uses(); !use.Done(); use.Advance()) {
796 if (use.value()->IsInstruction()) {
797 ASSERT(HInstruction::cast(use.value())->IsLinked());
798 }
799 }
793 } 800 }
794 #endif 801 #endif
795 802
796 803
797 void HDummyUse::PrintDataTo(StringStream* stream) { 804 void HDummyUse::PrintDataTo(StringStream* stream) {
798 value()->PrintNameTo(stream); 805 value()->PrintNameTo(stream);
799 } 806 }
800 807
801 808
802 void HUnaryCall::PrintDataTo(StringStream* stream) { 809 void HUnaryCall::PrintDataTo(StringStream* stream) {
(...skipping 2131 matching lines...) Expand 10 before | Expand all | Expand 10 after
2934 2941
2935 2942
2936 void HCheckFunction::Verify() { 2943 void HCheckFunction::Verify() {
2937 HInstruction::Verify(); 2944 HInstruction::Verify();
2938 ASSERT(HasNoUses()); 2945 ASSERT(HasNoUses());
2939 } 2946 }
2940 2947
2941 #endif 2948 #endif
2942 2949
2943 } } // namespace v8::internal 2950 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698