Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm

Issue 12224052: Alternate NTP: Fix bug where shadow is not removed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm
index d90af3b9208faf6c3763f3ededec7d5920267d94..9063d7513e7533f3c0a71d16db7bc0798629db59 100644
--- a/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm
@@ -129,3 +129,14 @@ IN_PROC_BROWSER_TEST_F(PreviewableContentsControllerTest, NoShadowNTP) {
EXPECT_EQ([PreviewDropShadowView preferredHeight],
NSHeight(dropShadowFrame));
}
+
+// Verify that the shadow is hidden when hiding the preview.
+IN_PROC_BROWSER_TEST_F(PreviewableContentsControllerTest, HideShadow) {
+ chrome::search::Mode mode;
+ mode.mode = chrome::search::Mode::MODE_SEARCH_SUGGESTIONS;
+ instant_model_.SetPreviewState(mode, 10, INSTANT_SIZE_PERCENT);
+ EXPECT_TRUE([controller_ dropShadowView]);
+
+ [controller_ onActivateTabWithContents:web_contents_.get()];
+ EXPECT_FALSE([controller_ dropShadowView]);
+}
« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698