Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 12224049: Merge 140539 (Closed)

Created:
7 years, 11 months ago by pfeldman
Modified:
7 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 140539 > Web Inspector: only allow evaluateForTestInFrontend for front-ends under test. > https://bugs.webkit.org/show_bug.cgi?id=107523 > > Reviewed by Yury Semikhatsky. > > Source/WebCore: > > * inspector/InspectorController.cpp: > (WebCore::InspectorController::InspectorController): > (WebCore::InspectorController::isUnderTest): > (WebCore): > (WebCore::InspectorController::evaluateForTestInFrontend): > * inspector/InspectorController.h: > (InspectorController): > * inspector/InspectorFrontendClient.h: > (InspectorFrontendClient): > * inspector/InspectorFrontendClientLocal.cpp: > (WebCore::InspectorFrontendClientLocal::canAttachWindow): > (WebCore::InspectorFrontendClientLocal::isUnderTest): > (WebCore): > * inspector/InspectorFrontendClientLocal.h: > (InspectorFrontendClientLocal): > * inspector/InspectorFrontendHost.cpp: > (WebCore::InspectorFrontendHost::isUnderTest): > (WebCore): > * inspector/InspectorFrontendHost.h: > (InspectorFrontendHost): > * inspector/InspectorFrontendHost.idl: > * inspector/front-end/DOMExtension.js: > * inspector/front-end/InspectorFrontendHostStub.js: > (.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers): > (.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest): > * inspector/front-end/TestController.js: > (.invokeMethod): > (WebInspector.evaluateForTestInFrontend): > * inspector/front-end/externs.js: > > Source/WebKit/chromium: > > * public/WebDevToolsFrontendClient.h: > (WebKit::WebDevToolsFrontendClient::isUnderTest): > (WebDevToolsFrontendClient): > * src/InspectorFrontendClientImpl.cpp: > (WebKit::InspectorFrontendClientImpl::isUnderTest): > * src/InspectorFrontendClientImpl.h: > (InspectorFrontendClientImpl): > > Tools: > > * DumpRenderTree/chromium/DRTDevToolsClient.cpp: > (DRTDevToolsClient::isUnderTest): > (DRTDevToolsClient::call): > * DumpRenderTree/chromium/DRTDevToolsClient.h: > (DRTDevToolsClient): TBR=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -24 lines) Patch
M Source/WebCore/WebCore.exp.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorController.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendClientLocal.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/InspectorFrontendHost.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/DOMExtension.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/TestController.js View 1 chunk +7 lines, -18 lines 0 comments Download
M Source/WebCore/inspector/front-end/externs.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/public/WebDevToolsFrontendClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/InspectorFrontendClientImpl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/DRTDevToolsClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/DRTDevToolsClient.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
pfeldman
7 years, 11 months ago (2013-02-07 09:26:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698