Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 12224031: Add code attribute into onKeyEvent argument. (Closed)

Created:
7 years, 10 months ago by Seigo Nonaka
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add code attribute into onKeyEvent argument. The "code" holds the identification of physical key. Unlike to "key" value, this value is not affected on current keyboard layout or modifier state. BUG=169993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181846

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/input_ime.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Seigo Nonaka
7 years, 10 months ago (2013-02-06 15:04:07 UTC) #1
Seigo Nonaka
ping? just in case.
7 years, 10 months ago (2013-02-08 07:38:10 UTC) #2
Zachary Kuznia
lgtm
7 years, 10 months ago (2013-02-08 07:43:52 UTC) #3
Seigo Nonaka
zork: Thank you for your review. Adding Matt as the owner of Extension. Could you ...
7 years, 10 months ago (2013-02-08 07:57:02 UTC) #4
Seigo Nonaka
Matt: ping? just in case. I'm sorry to rush you.
7 years, 10 months ago (2013-02-11 18:12:47 UTC) #5
Matt Perry
LGTM Note that TEST= should be instructions for QA. If you don't have instructions, just ...
7 years, 10 months ago (2013-02-11 19:38:51 UTC) #6
Seigo Nonaka
Sure, Thank you. https://codereview.chromium.org/12224031/diff/1/chrome/common/extensions/api/input_ime.json File chrome/common/extensions/api/input_ime.json (right): https://codereview.chromium.org/12224031/diff/1/chrome/common/extensions/api/input_ime.json#newcode18 chrome/common/extensions/api/input_ime.json:18: "code": {"type": "string", "description": "Value of ...
7 years, 10 months ago (2013-02-12 02:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12224031/5002
7 years, 10 months ago (2013-02-12 02:23:52 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98448
7 years, 10 months ago (2013-02-12 03:31:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12224031/5002
7 years, 10 months ago (2013-02-12 03:47:14 UTC) #10
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 04:46:09 UTC) #11
Message was sent while issue was closed.
Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698