Extract UploadRangeOperationBase class from ResumeUploadOperation.

Extract UploadRangeOperationBase class from ResumeUploadOperation.

The newly being introduced class GetUploadStatusOperation looks very similar
to ResumeUploadOperation, especially the access url, http method, and how to
handle the response from the server. The diff should be the request header
and body (content) (along with it, progress update).
As a preparation of the implemetation of GetUploadStatusOperation,
the base class is extracted.

BUG=148632
TEST=Ran unit_tests


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181279

[hidehiko, 2013-02-06 15:03:43]

This CL depends on https://codereview.chromium.org/12224026/,
which is LGTM'ed, but still is in CQ.
The following CLs which depend on this CL will be sent to you for the code
review.

Thank you for your review in advance,
- hidehiko

[hashimoto, 2013-02-07 05:40:19]

On 2013/02/06 15:03:43, hidehiko wrote:
> This CL depends on https://codereview.chromium.org/12224026/,
You meant https://codereview.chromium.org/12235002/?
> which is LGTM'ed, but still is in CQ.
> The following CLs which depend on this CL will be sent to you for the code
> review.
> 
> Thank you for your review in advance,
> - hidehiko

[satorux1, 2013-02-07 05:43:34]

https://codereview.chromium.org/12224026/diff/10005/chrome/browser/google_api...
File chrome/browser/google_apis/gdata_wapi_operations.h (right):

https://codereview.chromium.org/12224026/diff/10005/chrome/browser/google_api...
chrome/browser/google_apis/gdata_wapi_operations.h:559: const ResumeUploadParams
params_;
Can we replace params_ with some member variables? Looks there aren't many.

[hidehiko, 2013-02-07 06:18:22]

Thank you for your review.

>> This CL depends on https://codereview.chromium.org/12224026/,
> You meant https://codereview.chromium.org/12235002/?

Oops, yes, you're right. This depends on 12235002.

Could you take another look?

https://codereview.chromium.org/12224026/diff/10005/chrome/browser/google_api...
File chrome/browser/google_apis/gdata_wapi_operations.h (right):

https://codereview.chromium.org/12224026/diff/10005/chrome/browser/google_api...
chrome/browser/google_apis/gdata_wapi_operations.h:559: const ResumeUploadParams
params_;
On 2013/02/07 05:43:34, satorux1 wrote:
> Can we replace params_ with some member variables? Looks there aren't many.

Done.

[satorux1, 2013-02-07 06:42:41]

LGTM

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_operations.cc (right):

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_operations.cc:743: buf_(params.buf) {}
nit: move } to the next line?

[hashimoto, 2013-02-07 06:43:33]

lgtm

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_operations.cc (right):

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_operations.cc:778: *upload_content =
std::string(buf_->data(), end_position_ - start_position_);
nit: How about DCHECK_GE(end_position_, start_position_) here or in the ctor?

[kinaba, 2013-02-07 07:00:10]

lgtm

[hidehiko, 2013-02-07 07:57:06]

Thank you for your review. Submitting...

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
File chrome/browser/google_apis/gdata_wapi_operations.cc (right):

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_operations.cc:743: buf_(params.buf) {}
On 2013/02/07 06:42:41, satorux1 wrote:
> nit: move } to the next line?

Done.

https://codereview.chromium.org/12224026/diff/4005/chrome/browser/google_apis...
chrome/browser/google_apis/gdata_wapi_operations.cc:778: *upload_content =
std::string(buf_->data(), end_position_ - start_position_);
On 2013/02/07 06:43:33, hashimoto wrote:
> nit: How about DCHECK_GE(end_position_, start_position_) here or in the ctor?

Added in ctor.

[commit-bot: I haz the power, 2013-02-07 07:57:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12224026/7009

[commit-bot: I haz the power, 2013-02-07 10:50:43]

Change committed as 181279