Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 12224019: Add SpdyFramerDebugVisitorInterface for later usage in stats collecting (Closed)

Created:
7 years, 10 months ago by akalin
Modified:
7 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add SpdyFramerDebugVisitorInterface for later usage in stats collecting and more! Lands server change 32048876. Also fixes test expectations when USE_SYSTEM_ZLIB is not set. Also add compiler_specific.h include for OVERRIDE keywords. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181087

Patch Set 1 #

Patch Set 2 : Fix test failures, add OVERRIDE #

Total comments: 3

Patch Set 3 : Add include #

Patch Set 4 : Fix Windows compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -1 line) Patch
M net/spdy/spdy_framer.h View 3 chunks +24 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 3 7 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+rch for review https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc File net/spdy/spdy_framer_test.cc (right): https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc#newcode925 net/spdy/spdy_framer_test.cc:925: 93u, I do it this way ...
7 years, 10 months ago (2013-02-06 00:25:07 UTC) #1
akalin
https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc File net/spdy/spdy_framer_test.cc (right): https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc#newcode925 net/spdy/spdy_framer_test.cc:925: 93u, On 2013/02/06 00:25:07, akalin wrote: > I do ...
7 years, 10 months ago (2013-02-06 00:29:01 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc File net/spdy/spdy_framer_test.cc (right): https://codereview.chromium.org/12224019/diff/2001/net/spdy/spdy_framer_test.cc#newcode925 net/spdy/spdy_framer_test.cc:925: 93u, On 2013/02/06 00:29:01, akalin wrote: > On ...
7 years, 10 months ago (2013-02-06 00:32:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/12224019/4001
7 years, 10 months ago (2013-02-06 00:38:12 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-06 01:24:15 UTC) #5
akalin
On 2013/02/06 00:32:29, Ryan Hamilton wrote: > Either way is fine with me. Looks like ...
7 years, 10 months ago (2013-02-06 20:05:24 UTC) #6
commit-bot: I haz the power
7 years, 10 months ago (2013-02-06 20:16:44 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698