Issue 12223111: Revert 178168

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12223111: Revert 178168 (Closed)

Created:
7 years, 10 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 10 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 178168 > Partially revert "Don't include web apps with empty names into autocomplete search." > > This reverts commit http://src.chromium.org/viewvc/chrome?view=rev&revision=154070. > Changing manifest was unnecessary to fix Omnibox issue. > But change introduced unexpected issue with cloud print dialog hosted under www.google.com/cloudprint/ > > If dialog needs to "Sign in" and app's urls list includes dialog url, then "Sign in" is opened in new windows instead of current one. It completely breaks cloud print flow. > > > BUG=170301 > > > Review URL: https://chromiumcodereview.appspot.com/12030002 BUG=170301, 175696 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182041

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/cloud_print_app/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)