content/browser/renderer_host/render_widget_host_impl.cc - Issue 12223106: Properly Remove Autofill Keyboard Listener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 12223106: Properly Remove Autofill Keyboard Listener. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixing broken tests Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index 543540725d6e35c214fe0ccfdbeb4740422f9a7a..125bf87466c5cb93a209306f94fbd3243713964d 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1221,6 +1221,9 @@ void RenderWidgetHostImpl::AddKeyboardListener(KeyboardListener* listener) {

void RenderWidgetHostImpl::RemoveKeyboardListener(

KeyboardListener* listener) {

+ // Ensure that the element is actually in the list.

+ DCHECK(std::find(keyboard_listeners_.begin(), keyboard_listeners_.end(),

+ listener) != keyboard_listeners_.end());

keyboard_listeners_.remove(listener);

}