chrome/browser/autofill/autofill_external_delegate.cc - Issue 12223106: Properly Remove Autofill Keyboard Listener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 12223106: Properly Remove Autofill Keyboard Listener. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/autofill/autofill_external_delegate.cc

diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc

index 1bc339d51f0588471dff640281d1a76654b9a9bd..39d99a1f4ef64b82be55907a45d5f1640ae34064 100644

--- a/chrome/browser/autofill/autofill_external_delegate.cc

+++ b/chrome/browser/autofill/autofill_external_delegate.cc

@@ -279,8 +279,9 @@ void AutofillExternalDelegate::ClearPreviewedForm() {

void AutofillExternalDelegate::HideAutofillPopup() {

if (controller_) {

- controller_->Hide();

OnPopupHidden(controller_.get());

+ // Hide deletes the controller so all other actions must be done before it.

+ controller_->Hide();

}