Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 12223100: Disable repeatedly failing trybot panel tests. (Closed)

Created:
7 years, 10 months ago by Randy Smith (Not in Mondays)
Modified:
7 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Disable repeatedly failing trybot panel tests. BUG=175760 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182290

Patch Set 1 #

Patch Set 2 : Fixed brainos #

Total comments: 1

Patch Set 3 : Added comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -13 lines) Patch
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 2 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_browsertest.cc View 1 2 4 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_resize_browsertest.cc View 1 2 6 chunks +45 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
raymes
lgtm https://codereview.chromium.org/12223100/diff/2001/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (right): https://codereview.chromium.org/12223100/diff/2001/chrome/browser/ui/panels/panel_browsertest.cc#newcode1135 chrome/browser/ui/panels/panel_browsertest.cc:1135: // http://crbug.com/175760 Optional: Just add a quick comment ...
7 years, 10 months ago (2013-02-12 18:55:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/12223100/5001
7 years, 10 months ago (2013-02-12 20:30:40 UTC) #2
commit-bot: I haz the power
Presubmit check for 12223100-5001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-12 20:30:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/12223100/5001
7 years, 10 months ago (2013-02-12 20:35:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/12223100/5001
7 years, 10 months ago (2013-02-13 19:36:41 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-13 19:36:42 UTC) #6
Failed to apply patch for chrome/browser/ui/panels/panel_drag_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/panels/panel_drag_browsertest.cc
  Hunk #3 FAILED at 1267.
  Hunk #4 succeeded at 1348 (offset -6 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/ui/panels/panel_drag_browsertest.cc.rej

Patch:       chrome/browser/ui/panels/panel_drag_browsertest.cc
Index: chrome/browser/ui/panels/panel_drag_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_drag_browsertest.cc
b/chrome/browser/ui/panels/panel_drag_browsertest.cc
index
08943efa73a5f68f799f1d546fd1730e414fc6c9..7db46fd5bcfe3a838a7cc85638f5102ba9ca26d2
100644
--- a/chrome/browser/ui/panels/panel_drag_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_drag_browsertest.cc
@@ -1076,7 +1076,13 @@ IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest,
DetachAndCancel) {
   panel_manager->CloseAll();
 }
 
-IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, Attach) {
+// http://crbug.com/175760; several panel tests failing regularly on mac.
+#if defined(OS_MAC)
+#define MAYBE_Attach DISABLED_Attach
+#else
+#define MAYBE_Attach Attach
+#endif
+IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, MAYBE_Attach) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   DockedPanelCollection* docked_collection =
panel_manager->docked_collection();
   DetachedPanelCollection* detached_collection =
@@ -1136,7 +1142,13 @@ IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, Attach) {
   panel_manager->CloseAll();
 }
 
-IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, AttachAndCancel) {
+// http://crbug.com/175760; several panel tests failing regularly on mac.
+#if defined(OS_MAC)
+#define MAYBE_AttachAndCancel DISABLED_AttachAndCancel
+#else
+#define MAYBE_AttachAndCancel AttachAndCancel
+#endif
+IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest, MAYBE_AttachAndCancel) {
   PanelManager* panel_manager = PanelManager::GetInstance();
   DockedPanelCollection* docked_collection =
panel_manager->docked_collection();
   DetachedPanelCollection* detached_collection =
@@ -1255,7 +1267,8 @@ IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest,
DetachAttachAndCancel) {
 }
 
 // Disabled on GTK in metacity: http://crbug.com/167114
-#if defined(TOOLKIT_GTK)
+// http://crbug.com/175760; several panel tests failing regularly on mac.
+#if defined(TOOLKIT_GTK) || defined(OS_MAC)
 #define MAYBE_DetachWithSqueeze DISABLED_DetachWithSqueeze
 #else
 #define MAYBE_DetachWithSqueeze DetachWithSqueeze
@@ -1342,8 +1355,8 @@ IN_PROC_BROWSER_TEST_F(PanelDragBrowserTest,
MAYBE_DetachWithSqueeze) {
   panel_manager->CloseAll();
 }
 
-// http://crbug.com/143247
-#if defined(OS_LINUX)
+// http://crbug.com/143247, http://crbug.com/175760
+#if defined(OS_LINUX) || defined(OS_MAC)
 #define MAYBE_AttachWithSqueeze DISABLED_AttachWithSqueeze
 #else
 #define MAYBE_AttachWithSqueeze AttachWithSqueeze

Powered by Google App Engine
This is Rietveld 408576698