Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 12223089: Fixed a memory leak in v8 and another one in d8. (Closed)

Created:
7 years, 10 months ago by Sven Panne
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fixed a memory leak in v8 and another one in d8. Cleaned up a few tests on the way. This CL brings us down to 5 leaks for d8. Committed: http://code.google.com/p/v8/source/detail?r=13646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-lockers.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
7 years, 10 months ago (2013-02-12 11:41:35 UTC) #1
Yang
7 years, 10 months ago (2013-02-12 11:46:39 UTC) #2
On 2013/02/12 11:41:35, Sven Panne wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698